Page MenuHomePhabricator

[Cashtab[Alias] Clear registration input after broadcast
ClosedPublic

Authored by emack on Oct 7 2023, 03:29.

Details

Summary

Clear the input field for the alias registration component upon broadcast.

Test Plan

activate alias flag in config
npm start
navigate to Alias.js, register a new alias and observe the input field being cleared afterwards

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emack requested review of this revision.Oct 7 2023, 03:29

improve the state var organization in a separate diff and then rebase this.

cashtab/src/components/Alias/Alias.js
99 ↗(On Diff #42586)

aliasLength === aliasToRegister.length, this state var needs to go. can be a separate diff

101 ↗(On Diff #42586)

need to move away from using these multi-typed inputs. so this is false or a string?

also aliasToRegister === formData.aliasName ... needs to go.

This revision now requires changes to proceed.Oct 10 2023, 12:25
emack marked 2 inline comments as done.

Rebased to master after state var cleanup

This revision is now accepted and ready to land.Oct 16 2023, 13:20