Differential D14626

[avalanche] Document the staking rewards enable flag
ClosedPublic
Actions

Authored by Fabien on Oct 11 2023, 12:23.

Details

Reviewers

bytesofman

Group Reviewers

Restricted Project

Commits

rABC21d92f22eaa5: [avalanche] Document the staking rewards enable flag

Summary

This used to be a hidden flag, make it available via the help.

Test Plan

bitcoind -help

Check the flag is properly documented.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Oct 11 2023, 12:23

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 11 2023, 12:23

Fabien requested review of this revision.Oct 11 2023, 12:23

see inline for possible formatting nit

src/init.cpp
1284–1285 ↗	(On Diff #42630)	is this indentation intended? seems to be causing the phab feedback of "hey this other arg was removed", even tho seems to have just been indented here.

This revision is now accepted and ready to land.Oct 11 2023, 12:28

Fabien added inline comments.Oct 11 2023, 12:36

src/init.cpp
1284–1285 ↗	(On Diff #42630)	This is a bug, I added a trailing comma instead of a semicolon. Funnily it compiles and works as expected!

Harbormaster completed remote builds in B25323: Diff 42630.Oct 11 2023, 12:36

Fix comma vs semicolon

Harbormaster completed remote builds in B25324: Diff 42631.Oct 11 2023, 12:52

Closed by commit rABC21d92f22eaa5: [avalanche] Document the staking rewards enable flag (authored by Fabien). · Explain WhyOct 11 2023, 12:53

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC21d92f22eaa5: [avalanche] Document the staking rewards enable flag.

Revision Contents
Changeset List

Path

Size

src/

init.cpp

10 lines

test/

lint/

check-doc.py

1 line

Diff 42632

View Options

src/init.cpp