[e.cash] Add instructions on how to upgrade a node
ClosedPublic
Actions

Authored by Mengerian on Oct 11 2023, 23:22.

Details

Reviewers

johnkuney
Fabien

Group Reviewers

Restricted Project

Commits

rABCafbbbc44f889: [e.cash] Add instructions on how to upgrade a node

Summary

Help people who need instructions for how to actually upgrade their node

Test Plan

Run it locally to see that it looks good.
Follow the instructions to check that they work.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Mengerian created this revision.Oct 11 2023, 23:22

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 11 2023, 23:22

Mengerian requested review of this revision.Oct 11 2023, 23:22

Harbormaster completed remote builds in B25334: Diff 42647.Oct 11 2023, 23:22

johnkuney added inline comments.Oct 12 2023, 02:09

web/e.cash/pages/upgrade.js
96 ↗	(On Diff #42647)	dont put the <ul> inside <p>. This was causing that error you were seeing
98 ↗	(On Diff #42647)	may look cleaner with a <br /> between the line and the code. And could maybe add more space between list items. Could make a styled component for the list and add margin or padding to the list items

Fix error due to <ul> tag inside <p>
Use breaks to separate code from the preceding words

Harbormaster completed remote builds in B25335: Diff 42648.Oct 12 2023, 03:14

OK, I fixed the broken part, and added breaks before the code.
I don't know how to do the styled component stuff, so I'll leave that part out.

Looks good. Only nit is lose the spaces between the colons and the <br />'s, and up to you but maybe make it an ordered list <ol> instead if these steps are meant to be done in order

This revision now requires changes to proceed.Oct 12 2023, 03:59

Remove spaces before <br /> tags
Change outer list to ordered

Harbormaster completed remote builds in B25339: Diff 42653.Oct 12 2023, 14:20

Looks like the linter moved the <br /> tags to new lines anyway.
I changed the outer list, but left the sub-list unordered because: 1) it looks better that way, and 2) those commands don't need to be done in order

@bot preview-e.cash

Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://54.39.104.128:41876 for the next 60 minutes.