Page MenuHomePhabricator

[alias-server] Return pending registrations for a specified alias
ClosedPublic

Authored by bytesofman on Oct 24 2023, 22:30.

Details

Summary

Would be useful for a registering user to know if there are pending registration txs already on the network for an alias he is attempting to register

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emack requested changes to this revision.Oct 25 2023, 01:53
emack added a subscriber: emack.

Worth noting this would be implemented at the point of pressing the register button and not when the user is inputting the alias name with each keystroke being parsed for validity. I can add it as a conditional text render in the registration confirmation modal (preparePreviewModal).

Can I confirm we're still retaining the existing wallet specific pending list from the /address/ endpoint? The Pending Aliases dropdown will still display pending aliases associated with the active wallet and I will replace the pending check logic in D14611 so that it will compare with the pending prop from this /alias/ endpoint response.

This revision now requires changes to proceed.Oct 25 2023, 01:53

Can I confirm we're still retaining the existing wallet specific pending list from the /address/ endpoint?

Yes, this doesn't alter existing endpoints. Just adds pending info to the /alias/ endpoint.

I'm not clear on what your requested changes are based on the feedback, marking 'request review'

This revision is now accepted and ready to land.Oct 25 2023, 21:57