Page MenuHomePhabricator
Differential D14702

[electrum] Fix various strings that were wrong, inconsistent or not translatable
ClosedPublic
Actions

Authored by PiRK on Oct 30 2023, 11:03.

Details

Reviewers
bytesofman
Group Reviewers
Restricted Project
Commits
rABC56eb12dfb561: [electrum] Fix various strings that were wrong, inconsistent or not translatable
Summary

The titles of load / save dialogs used the wrong title in various
locations, this fixes it.

This also makes some previously untranlatable string translatable.

This is a backport of electroncash#2718

Test Plan

In the contacts tab, right-click and select "Import contacts"

I'm not sure how to reach the invoice importing dialog, but the fix is trivially correct.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Oct 30 2023, 11:03
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 30 2023, 11:03
PiRK requested review of this revision.Oct 30 2023, 11:03
teamcity edited the summary of this revision. (Show Details)Oct 30 2023, 11:03
Harbormaster completed remote builds in B25473: Diff 42852.Oct 30 2023, 11:04
PiRK retitled this revision from Fix various strings that were wrong, inconsistent or not translatable to [electrum] Fix various strings that were wrong, inconsistent or not translatable.Oct 30 2023, 12:07
bytesofman accepted this revision.Oct 30 2023, 17:55
This revision is now accepted and ready to land.Oct 30 2023, 17:55
Closed by commit rABC56eb12dfb561: [electrum] Fix various strings that were wrong, inconsistent or not translatable (authored by EchterAgo, committed by PiRK). · Explain WhyOct 31 2023, 07:26
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC56eb12dfb561: [electrum] Fix various strings that were wrong, inconsistent or not translatable.

Revision Contents
Changeset List

PathSize
electrum/
electrumabc_gui/
qt/
2 lines
2 lines
2 lines
2 lines

Diff 42868

View Options

electrum/electrumabc_gui/qt/contact_list.py

Loading...
View Options

electrum/electrumabc_gui/qt/installwizard.py

Loading...
View Options

electrum/electrumabc_gui/qt/invoice_list.py

Loading...
View Options

electrum/electrumabc_gui/qt/main_window.py

Loading...