Page MenuHomePhabricator
Differential D14744

[avalanche] Add invalidateavalancheproof and reconsideravalancheproof RPCs
ClosedPublic
Actions

Authored by Fabien on Nov 6 2023, 17:11.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABC0f2dc0a1d6c6: [avalanche] Add invalidateavalancheproof and reconsideravalancheproof RPCs
Summary

This let a user manually change the status of an avalanche proof. This
is mainly useful in tests to change the vote of a node.

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Nov 6 2023, 17:11
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 6 2023, 17:11
Fabien requested review of this revision.Nov 6 2023, 17:11
Harbormaster completed remote builds in B25543: Diff 42965.Nov 6 2023, 17:24
PiRK accepted this revision.Nov 6 2023, 19:06
This revision is now accepted and ready to land.Nov 6 2023, 19:06
Klakurka added a subscriber: Klakurka.Nov 7 2023, 03:20
Klakurka added inline comments.
doc/release-notes.md
7 ↗(On Diff #42965)

Nit: these RPCs aren't bug fixes, right?

Fabien added inline comments.Nov 7 2023, 07:23
doc/release-notes.md
7 ↗(On Diff #42965)

Nope, I just copy pasted the usual sentence we put in every release, will fix

Fabien updated this revision to Diff 42968.Nov 7 2023, 07:25

Fix release note

Harbormaster completed remote builds in B25546: Diff 42968.Nov 7 2023, 07:38
Closed by commit rABC0f2dc0a1d6c6: [avalanche] Add invalidateavalancheproof and reconsideravalancheproof RPCs (authored by Fabien). · Explain WhyNov 7 2023, 20:06
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC0f2dc0a1d6c6: [avalanche] Add invalidateavalancheproof and reconsideravalancheproof RPCs.

Revision Contents
Changeset List

PathSize
doc/
4 lines
src/
avalanche/
1 line
5 lines
4 lines
14 lines
test/
2 lines
rpc/
112 lines
test/
functional/
151 lines

Diff 42982

View Options

doc/release-notes.md

Loading...
View Options

src/avalanche/peermanager.h

Loading...
View Options

src/avalanche/peermanager.cpp

Loading...
View Options

src/avalanche/processor.h

Loading...
View Options

src/avalanche/processor.cpp

Loading...
View Options

src/avalanche/test/processor_tests.cpp

Loading...
View Options

src/rpc/avalanche.cpp

Loading...
View Options

test/functional/abc_rpc_invalidateavalancheproof.py

Loading...