Page MenuHomePhabricator

[electrum] log: only log in verbose mode in CachedWalletPasswordWidget

Authored by PiRK on Fri, Nov 10, 09:19.



My intention was to log this message only in verbose mode, but it turns out print_msg always logs the message. We need to use print_error instead. This is a bit counterintuitive to me, as in other logging frameworks the severity of errors is higher than the severity of info messages and debug messages.

This antipattern of using print_error for debbuging logs will be cleaned out of the codebase when I eventually backport

Test Plan

repeat the test plan from D14729 with and without the -v command line option, verify that the message is only printed in verbose mode

Diff Detail

rABC Bitcoin ABC
Lint Not Applicable
Tests Not Applicable