Page MenuHomePhabricator

[electrum] fix integer overflow for the Proof total amount

Authored by PiRK on Tue, Nov 14, 07:16.


Group Reviewers
Restricted Project
rABCf3c21cd60f5b: [electrum] fix integer overflow for the Proof total amount

PyQt translates python integers to signed 32 bits int when emitting a int in a signal.
We need to specifically emit a 64 bit integer. See

Also apply the same fix to the two signals that I previously fixed in a different way (with a larger performance overhead) in

Test Plan

load a proof with a total stake of more than 21,474,836.47 XEC, check the amount is displayed correctly.
Select coins and addresses of various amounts, check the selected amount displayed in the status bar.

Diff Detail

rABC Bitcoin ABC
Lint Not Applicable
Tests Not Applicable

Event Timeline

PiRK requested review of this revision.Tue, Nov 14, 07:16
PiRK planned changes to this revision.Tue, Nov 14, 07:41

testing a better solution

PiRK edited the summary of this revision. (Show Details)
PiRK edited the test plan for this revision. (Show Details)

specifically emit a uint64. This is significantly less heavy than emitting a PyObject in the C++ call

remove the no longer relevant comment

This revision is now accepted and ready to land.Tue, Nov 14, 08:05