Differential D14793

[e.cash] Remove old countdown from anoucment bar
ClosedPublic
Actions

Authored by johnkuney on Nov 15 2023, 19:32.

Details

Reviewers

bytesofman

Group Reviewers

Restricted Project

Commits

rABC67019412ed27: [e.cash] Remove old countdown from anoucment bar

Summary

Removing the old countdown from the static annoucment bar as no long needed

Test Plan

Preview the site, should be no changes to current build

Diff Detail

Repository

rABC Bitcoin ABC

Branch

ecash-annoucement-bar-remove-counter

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 25631
Build 50842: Build Diff
Build 50841: arc lint + arc unit

Event Timeline

johnkuney created this revision.Nov 15 2023, 19:32

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 15 2023, 19:32

johnkuney requested review of this revision.Nov 15 2023, 19:32

Harbormaster completed remote builds in B25631: Diff 43103.Nov 15 2023, 19:32

@bot preview-e.cash

Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://51.178.130.230:41456 for the next 60 minutes.

nothing is changing here so hard to say what is actually being done. will see impact in diff that implements this component. worthwhile to have a general announcement component and a special countdown component in the codebase, as both are expected to be used at regular intervals.

This revision is now accepted and ready to land.Nov 15 2023, 19:41

Closed by commit rABC67019412ed27: [e.cash] Remove old countdown from anoucment bar (authored by johnkuney). · Explain WhyNov 15 2023, 19:45

This revision was automatically updated to reflect the committed changes.

johnkuney added a commit: rABC67019412ed27: [e.cash] Remove old countdown from anoucment bar.