Differential D14799

[chronik] Don't erase the default websocket timeout un chronik_ws_script
ClosedPublic
Actions

Authored by Fabien on Nov 16 2023, 13:31.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC7cd4fe942ef0: [chronik] Don't erase the default websocket timeout un chronik_ws_script

Summary

The timeout is set at client creation time and adapts itself to the situation, with an extended value for the slow machines. Overriding the default timeout where it is not useful only increases the risk of timeout.

Test Plan

./test/functional/test_runner.py chronik_ws_script

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Nov 16 2023, 13:31

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 16 2023, 13:31

Fabien requested review of this revision.Nov 16 2023, 13:31

Harbormaster completed remote builds in B25637: Diff 43116.Nov 16 2023, 13:50

PiRK accepted this revision.Nov 16 2023, 13:58

This revision is now accepted and ready to land.Nov 16 2023, 13:58

Closed by commit rABC7cd4fe942ef0: [chronik] Don't erase the default websocket timeout un chronik_ws_script (authored by Fabien). · Explain WhyNov 16 2023, 14:03

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC7cd4fe942ef0: [chronik] Don't erase the default websocket timeout un chronik_ws_script.

Revision Contents
Changeset List

Path

Size

test/

functional/

chronik_ws_script.py

4 lines

Diff 43122

View Options

test/functional/chronik_ws_script.py

[chronik] Don't erase the default websocket timeout un chronik_ws_scriptClosedPublicActions