Page MenuHomePhabricator

[electrum] don't show error if the Aux Key Dialog's password prompt is cancelled
ClosedPublic

Authored by PiRK on Nov 23 2023, 12:21.

Details

Summary

If the user opened the Aux Key dialog via the menu or the "Genereate Key" button in the Delegation Editor, and then cancelled the password prompt, it showed an error popup with a python stack trace. Handle this situation and just show a warning with an informative message.

Also don't set the suggested_delegated_key_and_index attribute in the Delegation editor, to avoid incrementing the aux key index if the user decides to later paste a public key from an unknown source and generate a delegation.

Test Plan

Show the aux key dialog (both via the wallet menu and the delegation editor) in an encrypted wallet and cancel the password prompt.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK requested review of this revision.Nov 23 2023, 12:21
bytesofman added a subscriber: bytesofman.

FYI I get a rebase issue when I attempt to arc patch this diff

 INFO  Base commit is not in local repository; trying to fetch.
Created and checked out branch arcpatch-D14842.


    This diff is against commit 771a69d9f8a859a32784bb345aea4b03083f0fd5, but
    the commit is nowhere in the working copy. Try to apply it against the
    current working copy state? (9e9fb4a51943db19f1c871e713a03cdf94ed285b)
    [Y/n]

could be a rebase issue but also could be in my repo.

otherwise test plan checks out, code looks good

This revision is now accepted and ready to land.Nov 23 2023, 13:00

I accidentally based this on D14839 and missed the dependency