Differential D14855

[guix] disable BIP70 for the guix build
ClosedPublic
Actions

Authored by PiRK on Nov 27 2023, 14:47.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCa07b9766215b: [guix] disable BIP70 for the guix build

Summary

The guix build failed to find protobuf since D14254 for an unknown reason. And even before D14254, there was an issue with the guix build using the native protobuf library isntead of the cross-compiled one:

...
-- Found SQLite3: /bitcoin/depends/x86_64-linux-gnu/include (found suitable version "3.32.1", minimum required is "3.7.17")
-- Found ZeroMQ component zmq: /bitcoin/depends/x86_64-linux-gnu/lib/libzmq.a
-- Found ZeroMQ: /bitcoin/depends/x86_64-linux-gnu/include (found suitable version "4.3.1", minimum required is "4.1.5")
-- Found Protobuf: /bitcoin/depends/x86_64-linux-gnu/native/lib64/libprotobuf.a;-pthread (found version "3.21.12")
-- Found OpenSSL: /bitcoin/depends/x86_64-linux-gnu/lib/libcrypto.a (found version "1.1.1t")
...

Disable the component (BIP70) that require protobuf so we can maybe make more progress on the guix build.

For reference, the error that this removes is:

CMake Error in src/qt/CMakeLists.txt:
  Imported target "protobuf::libprotobuf" includes non-existent path

    "/bitcoin/depends/x86_64-linux-gnu/native/include"

  in its INTERFACE_INCLUDE_DIRECTORIES.  Possible reasons include:

  * The path was deleted, renamed, or moved to another location.

  * An install or uninstall procedure did not complete successfully.

  * The installation package was faulty and references files it does not
  provide.

Test Plan

contrib/guix-clean
contrib/guix-build

Check that the build produces the expected binaries and test them:

./distsrc-f12aa73c14b3-x86_64-linux-gnu/src/bitcoind

Note that we still have the same symbol-check failure as before:

[8/8] Running symbol-check.py on bitcoin-qt...
FAILED: src/qt/CMakeFiles/symbol-check-bitcoin-qt /bitcoin/distsrc-f12aa73c14b3-x86_64-linux-gnu/src/qt/CMakeFiles/symbol-check-bitcoin-qt
cd /bitcoin/distsrc-f12aa73c14b3-x86_64-linux-gnu/src/qt && /home/pierre/.guix-profile/bin/python3.9 /bitcoin/contrib/devtools/symbol-check.py /bitcoin/distsrc-f12aa73c14b3-x86_64-linux-gnu/src/qt/bitcoin-qt
/bitcoin/distsrc-f12aa73c14b3-x86_64-linux-gnu/src/qt/bitcoin-qt: symbol pthread_sigmask from unsupported version GLIBC_2.32(15)
/bitcoin/distsrc-f12aa73c14b3-x86_64-linux-gnu/src/qt/bitcoin-qt: failed IMPORTED_SYMBOLS