Page MenuHomePhabricator

[Cashtab][Alias] Simplify alias taken msg
ClosedPublic

Authored by emack on Dec 6 2023, 13:42.

Details

Reviewers
bytesofman
Group Reviewers
Restricted Project
Commits
rABCd945d7619d71: [Cashtab][Alias] Simplify alias taken msg
Summary

T3363

Simplify the alias taken status message as per UAT feedback.

Test Plan

npm test
npm start
enter a registered alias and ensure the This alias is already taken error is displayed with the register button disabled.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emack requested review of this revision.Dec 6 2023, 13:42
bytesofman requested changes to this revision.Dec 6 2023, 13:49
bytesofman added inline comments.
cashtab/src/components/Alias/Alias.js
170 ↗(On Diff #43437)

Can you make taken a link to the address on block explorer?

No one wants to read the address string, but I can see wanting to know what address has what alias.

This revision now requires changes to proceed.Dec 6 2023, 13:49
emack requested review of this revision.Dec 6 2023, 14:22

As discussed on tg, quite the complexity in squeezing html markup into a state var and somehow make React render it in html and not a string.

bytesofman requested changes to this revision.Dec 6 2023, 14:25

ok -- if we want to add this feature, should be handled in its own diff as will require some refactoring.

This revision now requires changes to proceed.Dec 6 2023, 14:25
This revision is now accepted and ready to land.Dec 6 2023, 14:25
This revision was automatically updated to reflect the committed changes.