Page MenuHomePhabricator
Differential D14948

[Cashtab] Better validation for multisend txs
ClosedPublic
Actions

Authored by bytesofman on Dec 7 2023, 23:40.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABC19e69463baca: [Cashtab] Better validation for multisend txs
Summary

This validation is currently handled in the Send.js component without CI unit testing. Improve test to return error line number. Add unit tests.

Remove tech debt + need this function for improved tx construction later.

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bytesofman created this revision.Dec 7 2023, 23:40
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 7 2023, 23:40
bytesofman requested review of this revision.Dec 7 2023, 23:40
Harbormaster completed remote builds in B25884: Diff 43498.Dec 7 2023, 23:43
PiRK added a subscriber: PiRK.Dec 8 2023, 08:17

Looks good. New tests, all the old error cases are still handled,

PiRK accepted this revision.Dec 8 2023, 08:43
This revision is now accepted and ready to land.Dec 8 2023, 08:43
Closed by commit rABC19e69463baca: [Cashtab] Better validation for multisend txs (authored by bytesofman). · Explain WhyDec 8 2023, 13:21
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABC19e69463baca: [Cashtab] Better validation for multisend txs.

Revision Contents
Changeset List

PathSize
cashtab/
src/
components/
Send/
61 lines
utils/
__tests__/
57 lines
39 lines

Diff 43515

View Options

cashtab/src/components/Send/Send.js

Loading...
View Options

cashtab/src/utils/__tests__/validation.test.js

Loading...
View Options

cashtab/src/utils/validation.js

Loading...