Paths

Table of Contentst

Differential D14959

[Cashtab] Disable google analytics in extension using env var
ClosedPublic
Actions

Authored by bytesofman on Dec 10 2023, 20:21.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABCc3b8c306c9be: [Cashtab] Disable google analytics in extension using env var

Summary

Google analytics doesn't work in the extension and should be disabled there. (well, there is extension google analytics, but you implement it from the chrome store dev dashboard, you don't use the same implementation as a website).

Test Plan

npm run extension, load extension, check the console, observe no google analytics related error on app loading

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bytesofman created this revision.Dec 10 2023, 20:21

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 10 2023, 20:21

bytesofman requested review of this revision.Dec 10 2023, 20:21

bytesofman edited the summary of this revision. (Show Details)Dec 10 2023, 20:24

Cleaner implementation, no need for empty component if/else

before

after

Harbormaster completed remote builds in B25907: Diff 43533.Dec 10 2023, 20:35

Harbormaster completed remote builds in B25908: Diff 43534.Dec 10 2023, 20:38

PiRK accepted this revision.Dec 11 2023, 07:13

This revision is now accepted and ready to land.Dec 11 2023, 07:13

Closed by commit rABCc3b8c306c9be: [Cashtab] Disable google analytics in extension using env var (authored by bytesofman). · Explain WhyDec 11 2023, 17:45

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABCc3b8c306c9be: [Cashtab] Disable google analytics in extension using env var.

Revision Contents
Changeset List

Path

Size

cashtab/

extension/

public/

manifest.json

2 lines

src/

index.js

4 lines

Diff 43546

View Options

cashtab/extension/public/manifest.json