Page MenuHomePhabricator
Differential D15006

test: Change background_cs from pointer to reference in validation_chainstate_tests
ClosedPublic
Actions

Authored by PiRK on Dec 19 2023, 09:30.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC5ec09df7fd67: test: Change background_cs from pointer to reference in…
Summary

This changes background_cs from being a pointer to a reference to work
around a gcc false warning. Also, this makes the test easier to read.

Fixes https://github.com/bitcoin/bitcoin/issues/23101

Can be reviewed with --ignore-all-space.

This is a backport of core#23132

Test Plan

ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Dec 19 2023, 09:30
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 19 2023, 09:30
PiRK requested review of this revision.Dec 19 2023, 09:30
teamcity edited the summary of this revision. (Show Details)Dec 19 2023, 09:31
PiRK added inline comments.Dec 19 2023, 09:34
src/test/validation_chainstate_tests.cpp
116 ↗(On Diff #43662)

I'm not sure why I previously added this chainstates local var/alias. This is an opportunity to get closer to the source material.

Harbormaster completed remote builds in B25990: Diff 43662.Dec 19 2023, 10:01
Fabien accepted this revision.Dec 19 2023, 14:38
This revision is now accepted and ready to land.Dec 19 2023, 14:38
Closed by commit rABC5ec09df7fd67: test: Change background_cs from pointer to reference in… (authored by MarcoFalke <falke.marco@gmail.com>, committed by PiRK). · Explain WhyDec 20 2023, 09:46
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC5ec09df7fd67: test: Change background_cs from pointer to reference in….

Revision Contents
Changeset List

PathSize
src/
test/
29 lines

Diff 43686

View Options

src/test/validation_chainstate_tests.cpp

Loading...