remove unused BlockValidationResult::BLOCK_RECENT_CONSENSUS_CHANGE
ClosedPublic
Actions

Authored by PiRK on Dec 21 2023, 12:20.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC32dece1983fd: remove unused BlockValidationResult::BLOCK_RECENT_CONSENSUS_CHANGE

Summary

Nothing returns this status in this codebase, and there is no foreseeable need to keep these unreachable code branches.

Similar to D15014

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Dec 21 2023, 12:20

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 21 2023, 12:20

PiRK requested review of this revision.Dec 21 2023, 12:20

PiRK mentioned this in D15015: [kernel 0/n] Introduce bitcoin-chainstate.Dec 21 2023, 12:24

Harbormaster completed remote builds in B26033: Diff 43728.Dec 21 2023, 12:39

Fabien accepted this revision.Dec 21 2023, 13:29

This revision is now accepted and ready to land.Dec 21 2023, 13:29

Closed by commit rABC32dece1983fd: remove unused BlockValidationResult::BLOCK_RECENT_CONSENSUS_CHANGE (authored by PiRK). · Explain WhyDec 21 2023, 14:39

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC32dece1983fd: remove unused BlockValidationResult::BLOCK_RECENT_CONSENSUS_CHANGE.

Revision Contents
Changeset List

Path

Size

src/

consensus/

validation.h

8 lines

net_processing.cpp

1 line

Diff 43736

View Options

src/consensus/validation.h