Page MenuHomePhabricator
Differential D15036

remove unused CScript::IsCommitment
ClosedPublic
Actions

Authored by PiRK on Dec 22 2023, 09:30.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC4c471387d04b: remove unused CScript::IsCommitment
Summary

This was introduced in D147 to be used by an opt-in anti replay feature. The feature was sunset at block 530000 and removed from the codebase in D1412. Since then, the only callsite is a unit test.

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Dec 22 2023, 09:30
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 22 2023, 09:30
PiRK requested review of this revision.Dec 22 2023, 09:30
Fabien accepted this revision.Dec 22 2023, 09:44
This revision is now accepted and ready to land.Dec 22 2023, 09:44
Harbormaster completed remote builds in B26058: Diff 43762.Dec 22 2023, 09:45
Closed by commit rABC4c471387d04b: remove unused CScript::IsCommitment (authored by PiRK). · Explain WhyDec 22 2023, 09:52
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC4c471387d04b: remove unused CScript::IsCommitment.

Revision Contents
Changeset List

PathSize
src/
script/
1 line
21 lines
test/
1 line

Diff 43764

View Options

src/script/script.h

Loading...
View Options

src/script/script.cpp

Loading...
View Options

src/test/CMakeLists.txt

Loading...
View Options

src/test/script_commitment_tests.cpp

Loading...