Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC35395058fb3b: [Cashtab] Remove bignumber.js library

Summary

The slpMdm library uses bignumber.js, and makes it available. No need for Cashtab to have bignumber.js installed separately, and sometimes use both.

Ultimately would like to deprecate bignumber.js altogether, but for now it is still worth keeping slpMdm as we do not have a better library for making to-spec slp v1 txs.

Test Plan

npm test

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bytesofman created this revision.Jan 3 2024, 22:45

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 3 2024, 22:45

Harbormaster completed remote builds in B26126: Diff 43858.Jan 3 2024, 22:48

slpMdm.BN is also the same version of bignumber.js, https://github.com/simpleledger/slp-metadatamaker.js/blob/master/package.json#L33

Fabien added a subscriber: Fabien.Jan 4 2024, 11:09

Fabien added inline comments.

cashtab/src/components/Airdrop/Airdrop.js
4 ↗	(On Diff #43858)	Can't you just import BN ? even better: import BN from 'slpMdm' as BigNumber so you don't have to rename everything
151 ↗	(On Diff #43858)

bytesofman marked 2 inline comments as done.Jan 4 2024, 15:25

bytesofman added inline comments.

cashtab/src/components/Airdrop/Airdrop.js
4 ↗	(On Diff #43858)

cleaner imports and naming

Harbormaster completed remote builds in B26143: Diff 43880.Jan 4 2024, 15:30

rebase

back out unrelated import ordering change

Harbormaster completed remote builds in B26149: Diff 43894.Jan 4 2024, 17:41

Harbormaster completed remote builds in B26148: Diff 43893.

Fabien accepted this revision.Jan 4 2024, 21:17

This revision is now accepted and ready to land.Jan 4 2024, 21:17

Closed by commit rABC35395058fb3b: [Cashtab] Remove bignumber.js library (authored by bytesofman). · Explain WhyJan 4 2024, 21:49

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABC35395058fb3b: [Cashtab] Remove bignumber.js library.

[Cashtab] Remove bignumber.js library
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 43907

cashtab/package-lock.json

cashtab/package.json

cashtab/src/components/Airdrop/Airdrop.js

cashtab/src/components/Common/BalanceHeaderFiat.js

cashtab/src/components/Home/TokenList.js

cashtab/src/components/Send/SendToken.js

cashtab/src/components/Tokens/Tokens.js

cashtab/src/components/Tokens/tests/CreateTokenForm.test.js

cashtab/src/hooks/tests/migrations.test.js

cashtab/src/hooks/useWallet.js

cashtab/src/slpv1/index.js

cashtab/src/utils/mocks/chronikUtxos.js

cashtab/src/utils/mocks/mockCachedUtxos.js

cashtab/src/utils/tests/cashMethods.test.js

cashtab/src/utils/tests/formatting.test.js

cashtab/src/utils/cashMethods.js

cashtab/src/utils/chronik.js

cashtab/src/utils/formatting.js

cashtab/src/utils/validation.js

[Cashtab] Remove bignumber.js libraryClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 43907

cashtab/package-lock.json

cashtab/package.json

cashtab/src/components/Airdrop/Airdrop.js

cashtab/src/components/Common/BalanceHeaderFiat.js

cashtab/src/components/Home/TokenList.js

cashtab/src/components/Send/SendToken.js

cashtab/src/components/Tokens/Tokens.js

cashtab/src/components/Tokens/__tests__/CreateTokenForm.test.js

cashtab/src/hooks/__tests__/migrations.test.js

cashtab/src/hooks/useWallet.js

cashtab/src/slpv1/index.js

cashtab/src/utils/__mocks__/chronikUtxos.js

cashtab/src/utils/__mocks__/mockCachedUtxos.js

cashtab/src/utils/__tests__/cashMethods.test.js

cashtab/src/utils/__tests__/formatting.test.js

cashtab/src/utils/cashMethods.js

cashtab/src/utils/chronik.js

cashtab/src/utils/formatting.js

cashtab/src/utils/validation.js

[Cashtab] Remove bignumber.js library
ClosedPublic
Actions

Revision Contents
Changeset List

cashtab/src/components/Tokens/tests/CreateTokenForm.test.js

cashtab/src/hooks/tests/migrations.test.js

cashtab/src/utils/mocks/chronikUtxos.js

cashtab/src/utils/mocks/mockCachedUtxos.js

cashtab/src/utils/tests/cashMethods.test.js

cashtab/src/utils/tests/formatting.test.js