Page MenuHomePhabricator
Differential D15111

[herald] Call slpv2 empp txs ALP instead of slp v2
ClosedPublic
Actions

Authored by bytesofman on Jan 8 2024, 23:20.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCc13f16ef8ce7: [herald] Call slpv2 empp txs ALP instead of slp v2
Summary

New name for this token protocol. The formatting still needs to be improved, but this is pending indexing of ALP tokens. For now, they are labeled in a generic way that catches all EMPP txs.

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bytesofman created this revision.Jan 8 2024, 23:20
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 8 2024, 23:20
bytesofman requested review of this revision.Jan 8 2024, 23:20
bytesofman added inline comments.Jan 8 2024, 23:21
apps/ecash-herald/test/mocks/block.js
3418 ↗(On Diff #43982)

note that this mock is updated by running node scripts/generateMock.js

I haven't added the //@generated to the file, because it should be reviewed to confirm that the mock updates are consistent with the code that was changed.

Harbormaster completed remote builds in B26210: Diff 43982.Jan 8 2024, 23:24
Fabien accepted this revision.Jan 9 2024, 08:43
This revision is now accepted and ready to land.Jan 9 2024, 08:43
Closed by commit rABCc13f16ef8ce7: [herald] Call slpv2 empp txs ALP instead of slp v2 (authored by bytesofman). · Explain WhyJan 9 2024, 13:58
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABCc13f16ef8ce7: [herald] Call slpv2 empp txs ALP instead of slp v2.

Revision Contents
Changeset List

PathSize
apps/
ecash-herald/
constants/
2 lines
test/
mocks/
8 lines

Diff 43987

View Options

apps/ecash-herald/constants/op_return.js

Loading...
View Options

apps/ecash-herald/test/mocks/block.js

Loading...