Page MenuHomePhabricator
Differential D15185

[Cashtab] Do not disable amount field if null is passed
ClosedPublic
Actions

Authored by bytesofman on Jan 17 2024, 01:17.

Details

Reviewers
emack
Group Reviewers
Restricted Project
Commits
rABC2dcf23b92193: [Cashtab] Do not disable amount field if null is passed
Summary

Amount field should not be disabled if intent was to allow user to customize amount

Context: The way txInfoFromParams is being handled is currently in the middle of a significant refactor to handle bip21 spec updates.

This patch solves an immediate issue.

Test Plan

npm run extension
Test at https://proofofwriting.com/204/

Also make sure it still works at ecash.land

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bytesofman created this revision.Jan 17 2024, 01:17
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 17 2024, 01:17
bytesofman updated this revision to Diff 44267.Jan 17 2024, 01:18

correct syntax

bytesofman edited the summary of this revision. (Show Details)Jan 17 2024, 01:19
bytesofman edited the test plan for this revision. (Show Details)
Harbormaster completed remote builds in B26414: Diff 44266.Jan 17 2024, 01:20
bytesofman updated this revision to Diff 44268.Jan 17 2024, 01:21
bytesofman edited the summary of this revision. (Show Details)

back out format changes

Harbormaster completed remote builds in B26415: Diff 44267.Jan 17 2024, 01:21
bytesofman updated this revision to Diff 44269.Jan 17 2024, 01:21

minor version bump

bytesofman published this revision for review.Jan 17 2024, 01:21
Harbormaster completed remote builds in B26416: Diff 44268.Jan 17 2024, 01:23
Harbormaster completed remote builds in B26417: Diff 44269.
emack accepted this revision.Jan 17 2024, 02:37
emack added a subscriber: emack.

Tested all ok - amount input customizable via pow and disabled via ecash land

This revision is now accepted and ready to land.Jan 17 2024, 02:37
Closed by commit rABC2dcf23b92193: [Cashtab] Do not disable amount field if null is passed (authored by bytesofman). · Explain WhyJan 17 2024, 02:51
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABC2dcf23b92193: [Cashtab] Do not disable amount field if null is passed.

Revision Contents
Changeset List

PathSize
cashtab/
extension/
public/
2 lines
src/
components/
Send/
7 lines

Diff 44270

View Options

cashtab/extension/public/manifest.json

Loading...
View Options

cashtab/src/components/Send/SendXec.js

Loading...