Differential D15199

Fix a race in validationinterface_tests
ClosedPublic
Actions

Authored by Fabien on Jan 18 2024, 15:20.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC6ba1c1b97563: Fix a race in validationinterface_tests

Summary

Since the block_finalized callback now runs in the scheduler thread, the test is racy as there is concurrent access to the test variables. This diff simplify the test and fixes the race.

Test Plan

With TSAN:

ninja check-bitcoin

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Jan 18 2024, 15:20

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 18 2024, 15:20

Fabien requested review of this revision.Jan 18 2024, 15:20

Harbormaster completed remote builds in B26460: Diff 44323.Jan 18 2024, 15:47

@bot build-tsan

teamcity awarded a token.Jan 18 2024, 16:40

PiRK accepted this revision.Jan 19 2024, 07:27

This revision is now accepted and ready to land.Jan 19 2024, 07:27

Closed by commit rABC6ba1c1b97563: Fix a race in validationinterface_tests (authored by Fabien). · Explain WhyJan 19 2024, 08:22

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC6ba1c1b97563: Fix a race in validationinterface_tests.

Revision Contents
Changeset List

Path

Size

src/

test/

validationinterface_tests.cpp

53 lines

Diff 44351

View Options

src/test/validationinterface_tests.cpp

Fix a race in validationinterface_testsClosedPublicActions