Page MenuHomePhabricator
Differential D15243

[Cashtab] Remove unreachable loadStoredWallet migration helper fn
ClosedPublic
Actions

Authored by bytesofman on Jan 22 2024, 23:39.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCf3ae568974f9: [Cashtab] Remove unreachable loadStoredWallet migration helper fn
Summary

With D15256 landed, we can no longer pass isValidStoredWallet with the type of wallet that would benefit from the limited migration implemented in the confusingly named loadStoredWallet function

Delete this function. If Cashtab loads with an invalid wallet, it will populate wallet state from chronik and not by modifying params in the local storage object.

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bytesofman created this revision.Jan 22 2024, 23:39
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 22 2024, 23:39
Harbormaster completed remote builds in B26569: Diff 44465.Jan 22 2024, 23:42
teamcity added a comment.Jan 22 2024, 23:42
Build Bitcoin ABC Diffs / Diff Testing (cashtab-tests) failed.

Failed tests logs:

====== CashTab Unit Tests: Correctly executes cash utility functions Accepts a cachedWalletState that has not preserved BigNumber object types, and returns the same wallet state with BigNumber type re-instituted ======
TypeError: (0 , _cashMethods.loadStoredWallet) is not a function
    at Object.<anonymous> (/work/cashtab/src/utils/__tests__/cashMethods.test.js:988:32)
    at Promise.then.completed (/work/cashtab/node_modules/jest-circus/build/utils.js:298:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (/work/cashtab/node_modules/jest-circus/build/utils.js:231:10)
    at _callCircusTest (/work/cashtab/node_modules/jest-circus/build/run.js:316:40)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at _runTest (/work/cashtab/node_modules/jest-circus/build/run.js:252:3)
    at _runTestsForDescribeBlock (/work/cashtab/node_modules/jest-circus/build/run.js:126:9)
    at _runTestsForDescribeBlock (/work/cashtab/node_modules/jest-circus/build/run.js:121:9)
    at run (/work/cashtab/node_modules/jest-circus/build/run.js:71:3)
    at runAndTransformResultsToJestFormat (/work/cashtab/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at jestAdapter (/work/cashtab/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at runTestInternal (/work/cashtab/node_modules/jest-runner/build/runTest.js:367:16)
    at runTest (/work/cashtab/node_modules/jest-runner/build/runTest.js:444:34)
    at Object.worker (/work/cashtab/node_modules/jest-runner/build/testWorker.js:106:12)
====== CashTab Unit Tests: Correctly executes cash utility functions loadStoredWallet accepts undefined wallet state as input and outputs a zero balance wallet state ======
TypeError: (0 , _cashMethods.loadStoredWallet) is not a function
    at Object.<anonymous> (/work/cashtab/src/utils/__tests__/cashMethods.test.js:993:32)
    at Promise.then.completed (/work/cashtab/node_modules/jest-circus/build/utils.js:298:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (/work/cashtab/node_modules/jest-circus/build/utils.js:231:10)
    at _callCircusTest (/work/cashtab/node_modules/jest-circus/build/run.js:316:40)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at _runTest (/work/cashtab/node_modules/jest-circus/build/run.js:252:3)
    at _runTestsForDescribeBlock (/work/cashtab/node_modules/jest-circus/build/run.js:126:9)
    at _runTestsForDescribeBlock (/work/cashtab/node_modules/jest-circus/build/run.js:121:9)
    at run (/work/cashtab/node_modules/jest-circus/build/run.js:71:3)
    at runAndTransformResultsToJestFormat (/work/cashtab/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at jestAdapter (/work/cashtab/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at runTestInternal (/work/cashtab/node_modules/jest-runner/build/runTest.js:367:16)
    at runTest (/work/cashtab/node_modules/jest-runner/build/runTest.js:444:34)
    at Object.worker (/work/cashtab/node_modules/jest-runner/build/testWorker.js:106:12)

Each failure log is accessible here:
CashTab Unit Tests: Correctly executes cash utility functions Accepts a cachedWalletState that has not preserved BigNumber object types, and returns the same wallet state with BigNumber type re-instituted
CashTab Unit Tests: Correctly executes cash utility functions loadStoredWallet accepts undefined wallet state as input and outputs a zero balance wallet state

bytesofman updated this revision to Diff 44504.Jan 23 2024, 22:58

rebase

bytesofman updated this revision to Diff 44505.Jan 23 2024, 23:01

remove debug logs, remove unit tests

Harbormaster completed remote builds in B26595: Diff 44505.Jan 23 2024, 23:01
Harbormaster completed remote builds in B26594: Diff 44504.
teamcity added a comment.Jan 23 2024, 23:01
Build Bitcoin ABC Diffs / Diff Testing (cashtab-tests) failed.

Failed tests logs:

====== CashTab Unit Tests: Correctly executes cash utility functions Accepts a cachedWalletState that has not preserved BigNumber object types, and returns the same wallet state with BigNumber type re-instituted ======
TypeError: (0 , _cashMethods.loadStoredWallet) is not a function
    at Object.<anonymous> (/work/cashtab/src/utils/__tests__/cashMethods.test.js:988:32)
    at Promise.then.completed (/work/cashtab/node_modules/jest-circus/build/utils.js:298:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (/work/cashtab/node_modules/jest-circus/build/utils.js:231:10)
    at _callCircusTest (/work/cashtab/node_modules/jest-circus/build/run.js:316:40)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at _runTest (/work/cashtab/node_modules/jest-circus/build/run.js:252:3)
    at _runTestsForDescribeBlock (/work/cashtab/node_modules/jest-circus/build/run.js:126:9)
    at _runTestsForDescribeBlock (/work/cashtab/node_modules/jest-circus/build/run.js:121:9)
    at run (/work/cashtab/node_modules/jest-circus/build/run.js:71:3)
    at runAndTransformResultsToJestFormat (/work/cashtab/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at jestAdapter (/work/cashtab/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at runTestInternal (/work/cashtab/node_modules/jest-runner/build/runTest.js:367:16)
    at runTest (/work/cashtab/node_modules/jest-runner/build/runTest.js:444:34)
    at Object.worker (/work/cashtab/node_modules/jest-runner/build/testWorker.js:106:12)
====== CashTab Unit Tests: Correctly executes cash utility functions loadStoredWallet accepts undefined wallet state as input and outputs a zero balance wallet state ======
TypeError: (0 , _cashMethods.loadStoredWallet) is not a function
    at Object.<anonymous> (/work/cashtab/src/utils/__tests__/cashMethods.test.js:993:32)
    at Promise.then.completed (/work/cashtab/node_modules/jest-circus/build/utils.js:298:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (/work/cashtab/node_modules/jest-circus/build/utils.js:231:10)
    at _callCircusTest (/work/cashtab/node_modules/jest-circus/build/run.js:316:40)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at _runTest (/work/cashtab/node_modules/jest-circus/build/run.js:252:3)
    at _runTestsForDescribeBlock (/work/cashtab/node_modules/jest-circus/build/run.js:126:9)
    at _runTestsForDescribeBlock (/work/cashtab/node_modules/jest-circus/build/run.js:121:9)
    at run (/work/cashtab/node_modules/jest-circus/build/run.js:71:3)
    at runAndTransformResultsToJestFormat (/work/cashtab/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at jestAdapter (/work/cashtab/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at runTestInternal (/work/cashtab/node_modules/jest-runner/build/runTest.js:367:16)
    at runTest (/work/cashtab/node_modules/jest-runner/build/runTest.js:444:34)
    at Object.worker (/work/cashtab/node_modules/jest-runner/build/testWorker.js:106:12)

Each failure log is accessible here:
CashTab Unit Tests: Correctly executes cash utility functions Accepts a cachedWalletState that has not preserved BigNumber object types, and returns the same wallet state with BigNumber type re-instituted
CashTab Unit Tests: Correctly executes cash utility functions loadStoredWallet accepts undefined wallet state as input and outputs a zero balance wallet state

bytesofman updated this revision to Diff 44506.Jan 23 2024, 23:02

remove unused mock, lint

Harbormaster completed remote builds in B26596: Diff 44506.Jan 23 2024, 23:05
bytesofman updated this revision to Diff 44507.Jan 23 2024, 23:10

change isValidStoredWallet

Harbormaster completed remote builds in B26597: Diff 44507.Jan 23 2024, 23:12
bytesofman updated this revision to Diff 44539.Jan 24 2024, 17:38

rebase

bytesofman published this revision for review.Jan 24 2024, 17:40
bytesofman edited the summary of this revision. (Show Details)
Harbormaster completed remote builds in B26614: Diff 44539.Jan 24 2024, 17:54
bytesofman retitled this revision from [Cashtab] Deprecate loadStoredWallet migration helper fn to [Cashtab] Remove unreachable loadStoredWallet migration helper fn.Jan 24 2024, 18:02
Fabien accepted this revision.Jan 24 2024, 20:29
This revision is now accepted and ready to land.Jan 24 2024, 20:29
Closed by commit rABCf3ae568974f9: [Cashtab] Remove unreachable loadStoredWallet migration helper fn (authored by bytesofman). · Explain WhyJan 24 2024, 20:45
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABCf3ae568974f9: [Cashtab] Remove unreachable loadStoredWallet migration helper fn.

Revision Contents
Changeset List

PathSize
cashtab/
src/
hooks/
10 lines
utils/
__mocks__/
274 lines
__tests__/
19 lines
59 lines

Diff 44557

View Options

cashtab/src/hooks/useWallet.js

Loading...
View Options

cashtab/src/utils/__mocks__/mockCachedUtxos.js

Loading...
View Options

cashtab/src/utils/__tests__/cashMethods.test.js

Loading...
View Options

cashtab/src/utils/cashMethods.js

Loading...