Page MenuHomePhabricator
Differential D15306

fix flaky addrman_is_terrible test
ClosedPublic
Actions

Authored by PiRK on Jan 29 2024, 07:36.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCf1567e75b7f3: fix flaky addrman_is_terrible test
Summary

AddrInfo::IsTerrible takes an optional now argument defaulting to AdjustedTime(). Set the mocktime to ensure the adjusted time cannot change before the end of the test.

Test Plan

ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Jan 29 2024, 07:36
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 29 2024, 07:36
PiRK requested review of this revision.Jan 29 2024, 07:36
Harbormaster completed remote builds in B26705: Diff 44666.Jan 29 2024, 07:53
Fabien accepted this revision.Jan 29 2024, 08:53
This revision is now accepted and ready to land.Jan 29 2024, 08:53
Closed by commit rABCf1567e75b7f3: fix flaky addrman_is_terrible test (authored by PiRK). · Explain WhyJan 29 2024, 09:59
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABCf1567e75b7f3: fix flaky addrman_is_terrible test.

Revision Contents
Changeset List

PathSize
src/
test/
2 lines

Diff 44672

View Options

src/test/addrman_tests.cpp

Loading...