Page MenuHomePhabricator
Differential D15337

[Cashtab] Do not clearTimeout when alias component unmounts
ClosedPublic
Actions

Authored by bytesofman on Jan 31 2024, 00:53.

Details

Reviewers
emack
Group Reviewers
Restricted Project
Commits
rABCd83d64269649: [Cashtab] Do not clearTimeout when alias component unmounts
Summary

Since this is a timeout, and not an interval, we are only clearing one possible extra call.

In testing, this clearance is not working. So, stop trying to do this.

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bytesofman created this revision.Jan 31 2024, 00:53
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 31 2024, 00:53
Harbormaster completed remote builds in B26775: Diff 44758.Jan 31 2024, 00:56
bytesofman edited the summary of this revision. (Show Details)Jan 31 2024, 00:57
bytesofman updated this revision to Diff 44759.Jan 31 2024, 00:58

version bump

bytesofman published this revision for review.Jan 31 2024, 00:58
bytesofman added inline comments.
cashtab/src/components/Alias/Alias.js
177 ↗(On Diff #44759)

if you console.log(timeout clearing`, timeout)` here, then run this and leave the component -- you will not see the log

Harbormaster completed remote builds in B26776: Diff 44759.Jan 31 2024, 01:01
emack accepted this revision.Jan 31 2024, 06:56
This revision is now accepted and ready to land.Jan 31 2024, 06:56
Closed by commit rABCd83d64269649: [Cashtab] Do not clearTimeout when alias component unmounts (authored by bytesofman). · Explain WhyJan 31 2024, 11:18
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABCd83d64269649: [Cashtab] Do not clearTimeout when alias component unmounts.

Revision Contents
Changeset List

PathSize
cashtab/
2 lines
src/
components/
Alias/
8 lines

Diff 44776

View Options

cashtab/package.json

Loading...
View Options

cashtab/src/components/Alias/Alias.js

Loading...