Paths

Table of Contentst

Differential D15407

remove dependency to OpenSSL when building without BIP70 support
ClosedPublic
Actions

Authored by PiRK on Feb 8 2024, 13:58.

Details

Reviewers

bytesofman

Group Reviewers

Restricted Project

Commits

rABCcf768d54a248: remove dependency to OpenSSL when building without BIP70 support

Summary

OpenSSL headers do not need to be included when building bitcoin-qt without BIP70

There are other includes for OpenSSL in paymentrequestplus.{h|cpp}, but that module is only included in other source files in #ifdef ENABLE_BIP70 ... #endif blocks.

Test Plan

cmake .. -GNinja -DENABLE_BIP70=OFF
ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Feb 8 2024, 13:58

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 8 2024, 13:58

PiRK requested review of this revision.Feb 8 2024, 13:58

@bot build-without-bip70

teamcity awarded a token.Feb 8 2024, 14:00

nit

Harbormaster completed remote builds in B26994: Diff 45053.Feb 8 2024, 14:16

Harbormaster completed remote builds in B26995: Diff 45054.Feb 8 2024, 14:21

bytesofman accepted this revision.Feb 8 2024, 17:43

This revision is now accepted and ready to land.Feb 8 2024, 17:43

Closed by commit rABCcf768d54a248: remove dependency to OpenSSL when building without BIP70 support (authored by PiRK). · Explain WhyFeb 9 2024, 07:00

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCcf768d54a248: remove dependency to OpenSSL when building without BIP70 support.

PiRK mentioned this in D15428: remove unneeded includes when building without BIP70.Feb 12 2024, 16:16

PiRK mentioned this in rABCf87e0097045b: remove unneeded includes when building without BIP70.Feb 14 2024, 07:36

Revision Contents
Changeset List

Path

Size

doc/

dependencies.md

1 line

src/

qt/

paymentserver.cpp

2 lines

Diff 45087

View Options

doc/dependencies.md