Page MenuHomePhabricator
Differential D15408

[Cashtab] Upgrade react-ga implementation
ClosedPublic
Actions

Authored by bytesofman on Feb 8 2024, 14:27.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABC65cf0ff4c5e3: [Cashtab] Upgrade react-ga implementation
Summary

The current implementation is based off legacy react (componentDidMount etc) and also uses legacy routing. Will not work with react-router-dom v6.

Simplify and use latest version of react-ga.

Test Plan

Check dev console at https://cashtab-local-dev.netlify.app/#/wallet

I've added logging statements to this deployment

Confirm you see GA initialized on load and logging... as routes change.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bytesofman created this revision.Feb 8 2024, 14:27
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 8 2024, 14:27
Harbormaster completed remote builds in B26997: Diff 45056.Feb 8 2024, 14:32
bytesofman updated this revision to Diff 45057.Feb 8 2024, 14:32

remove debug log

bytesofman edited the test plan for this revision. (Show Details)Feb 8 2024, 14:33
bytesofman updated this revision to Diff 45058.Feb 8 2024, 14:35

remove unrelated format changes

Harbormaster completed remote builds in B26998: Diff 45057.Feb 8 2024, 14:36
bytesofman updated this revision to Diff 45059.Feb 8 2024, 14:37

cleanup

bytesofman published this revision for review.Feb 8 2024, 14:37
Harbormaster completed remote builds in B26999: Diff 45058.Feb 8 2024, 14:40
Harbormaster completed remote builds in B27000: Diff 45059.
PiRK accepted this revision.Feb 9 2024, 07:49
This revision is now accepted and ready to land.Feb 9 2024, 07:49
Closed by commit rABC65cf0ff4c5e3: [Cashtab] Upgrade react-ga implementation (authored by bytesofman). · Explain WhyFeb 9 2024, 12:11
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABC65cf0ff4c5e3: [Cashtab] Upgrade react-ga implementation.
bytesofman mentioned this in D15406: Revert "Revert "[Cashtab] Upgrade react-router-dom to latest version"".Feb 9 2024, 12:57
bytesofman mentioned this in rABC45401edfe066: Revert "Revert "[Cashtab] Upgrade react-router-dom to latest version"".Feb 9 2024, 14:12

Revision Contents
Changeset List

PathSize
cashtab/
4 lines
2 lines
src/
utils/
75 lines

Diff 45090

View Options

cashtab/package-lock.json

Loading...
View Options

cashtab/package.json

Loading...
View Options

cashtab/src/utils/GoogleAnalytics.js

Loading...