Paths

Table of Contentst

Differential D15433

fix more file permissions and shebangs
AbandonedPublic
Actions

Authored by PiRK on Feb 13 2024, 09:01.

Tags

None

Subscribers

None

Details

Reviewers

None

Group Reviewers

Restricted Project

Summary

This makes the file permissions and shebangs conform to the linter added in the next commit.

executable files must have a shebang
Electrum ABC source files are generally not supposed to be executable, even if they have a if __name__ == "__main__": section (running individual test suites can still be done with python -m electrumabc.tests.<filename>)

Related to D15421

Test Plan

Run the new linter in the next diff

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 27107
Build 53780: Build Diff	electrum-tests · check-buildbot · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 53779: arc lint + arc unit

Event Timeline

PiRK created this revision.Feb 13 2024, 09:01

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 13 2024, 09:01

PiRK requested review of this revision.Feb 13 2024, 09:01

Maybe we could apply the same rules as Electrum ABC to the test_framework/*.py modules that are not supposed to be executables and should not have a shebang, but that can be done in another diff. Currently they are all executable and have a shebang, so the linter will be happy.

Harbormaster completed remote builds in B27094: Diff 45175.Feb 13 2024, 09:28

Still working on the linter script

rebase

checking something

Harbormaster completed remote builds in B27107: Diff 45193.Feb 13 2024, 17:28

PiRK abandoned this revision.Feb 18 2024, 10:54

Revision Contents
Changeset List

Path

Size

contrib/

buildbot/

test/

mocks/

gitian-builder/

contrib/

verify-commits/

pre-push-hook.sh

2 lines

target-bin/

grab-packages.sh

upgrade-system.sh

qos/

teamcity/

buildAgent-autostart

testgen/

electrum/

contrib/

build-linux/

appimage/

scripts/

osx/

2 lines

electrumabc/

2 lines

old_mnemonic.py

2 lines

tests/

test_cashaddrenc.py

2 lines

test_schnorr.py

1 line

2 lines

test/

functional/

abc_feature_proof_cleanup.py

abc_p2p_compactproofs.py

abc_p2p_proof_inventory.py

abc_rpc_addavalanchenode.py

abc_rpc_avalancheproof.py

abc_rpc_buildavalancheproof.py

chronik_block.py

chronik_block_info.py

chronik_block_txs.py

chronik_blockchain_info.py

chronik_blocks.py

chronik_chronik_info.py

chronik_disallow_prune.py

chronik_mempool_conflicts.py

chronik_pause.py

chronik_plugins_setup.py

chronik_raw_tx.py

chronik_resync.py

chronik_script_confirmed_txs.py

chronik_script_history.py

chronik_script_unconfirmed_txs.py

chronik_script_utxos.py

chronik_serve.py

chronik_shutdown.py

chronik_spent_by.py

chronik_token_alp.py

chronik_token_broadcast_txs.py

chronik_token_burn.py

chronik_token_id_group.py

chronik_token_parse_failure.py

chronik_token_script_group.py

chronik_token_slp_fungible.py

chronik_token_slp_mint_vault.py

chronik_token_slp_nft1.py

chronik_tx_removal_order.py

feature_deterministic_chain_setup.py

feature_tx_version.py

setup_scripts/

chronik-client_block_and_blocks.py

chronik-client_blocktxs_and_tx_and_rawtx.py

chronik-client_script_utxos_and_history.py

setup_framework.py

test_framework/

Diff 45193

contrib/buildbot/test/mocks/init.py

Loading...

contrib/gitian-builder/contrib/verify-commits/pre-push-hook.sh

Loading...

contrib/gitian-builder/target-bin/grab-packages.sh

Loading...

contrib/gitian-builder/target-bin/init-build.sh

Loading...

contrib/gitian-builder/target-bin/upgrade-system.sh

Loading...

contrib/qos/tc.sh

Loading...

contrib/teamcity/buildAgent-autostart

Loading...

contrib/testgen/base58.py

Loading...

electrum/contrib/base.sh

Loading...

electrum/contrib/build-linux/appimage/scripts/common.sh

Loading...

electrum/contrib/osx/dmgbuild.spec

Loading...

electrum/electrumabc/interface.py

Loading...

electrum/electrumabc/old_mnemonic.py

Loading...

electrum/electrumabc/tests/test_cashaddrenc.py

Loading...

electrum/electrumabc/tests/test_schnorr.py

Loading...

electrum/electrumabc/transaction.py

Loading...

electrum/electrumabc/x509.py

Loading...

test/functional/abc_feature_proof_cleanup.py

Loading...

test/functional/abc_p2p_compactproofs.py

Loading...

test/functional/abc_p2p_proof_inventory.py

Loading...

test/functional/abc_rpc_addavalanchenode.py

Loading...

test/functional/abc_rpc_avalancheproof.py

Loading...

test/functional/abc_rpc_buildavalancheproof.py

Loading...

test/functional/chronik_block.py

Loading...

test/functional/chronik_block_info.py

Loading...

test/functional/chronik_block_txs.py

Loading...

test/functional/chronik_blockchain_info.py

Loading...

test/functional/chronik_blocks.py

Loading...

test/functional/chronik_chronik_info.py

Loading...

test/functional/chronik_disallow_prune.py

Loading...

test/functional/chronik_mempool_conflicts.py

Loading...

test/functional/chronik_pause.py

Loading...

test/functional/chronik_plugins_setup.py

Loading...

test/functional/chronik_raw_tx.py

Loading...

test/functional/chronik_resync.py

Loading...

test/functional/chronik_script_confirmed_txs.py

Loading...

test/functional/chronik_script_history.py

Loading...

test/functional/chronik_script_unconfirmed_txs.py

Loading...

test/functional/chronik_script_utxos.py

Loading...

test/functional/chronik_serve.py

Loading...

test/functional/chronik_shutdown.py

Loading...

test/functional/chronik_spent_by.py

Loading...

test/functional/chronik_token_alp.py

Loading...

test/functional/chronik_token_broadcast_txs.py

Loading...

test/functional/chronik_token_burn.py

Loading...

test/functional/chronik_token_id_group.py

Loading...

test/functional/chronik_token_parse_failure.py

Loading...

test/functional/chronik_token_script_group.py

Loading...

test/functional/chronik_token_slp_fungible.py

Loading...

test/functional/chronik_token_slp_mint_vault.py

Loading...

test/functional/chronik_token_slp_nft1.py

Loading...

test/functional/chronik_tx.py

Loading...

test/functional/chronik_tx_removal_order.py

Loading...

test/functional/feature_deterministic_chain_setup.py

Loading...

test/functional/feature_tx_version.py

Loading...

test/functional/setup_scripts/chronik-client_block_and_blocks.py

Loading...

test/functional/setup_scripts/chronik-client_blocktxs_and_tx_and_rawtx.py

Loading...

test/functional/setup_scripts/chronik-client_script_utxos_and_history.py

Loading...

test/functional/setup_scripts/ipc.py

Loading...

test/functional/setup_scripts/pathmagic.py

Loading...

test/functional/setup_scripts/setup_framework.py

Loading...

test/functional/test_framework/cdefs.py

Loading...