[Cashtab] Include mocked chronik for render tests of useWallet hook
ClosedPublic
Actions

Authored by bytesofman on Feb 22 2024, 18:03.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC8d00b54e39f8: [Cashtab] Include mocked chronik for render tests of useWallet hook

Summary

T3444

Include proper mocked chronik for these tests. Catches another nice case where we expect token cache to update if there is token info in tx history that is not currently in cache. Also prevents all of the API errors from these tests.

Test Plan

npm test

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bytesofman created this revision.Feb 22 2024, 18:03

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 22 2024, 18:03

Harbormaster completed remote builds in B27329: Diff 45492.Feb 22 2024, 18:06

remove test with leak issue

Harbormaster completed remote builds in B27341: Diff 45504.Feb 23 2024, 01:24

lint

Harbormaster completed remote builds in B27342: Diff 45505.Feb 23 2024, 01:28

bytesofman published this revision for review.Feb 23 2024, 01:28

bytesofman added inline comments.

cashtab/src/hooks/__tests__/useWalletStorage.test.js
87 ↗	(On Diff #45505)	A couple of points 1 - we do not really want to be testing `state`, we want to test the impact of state on the app. This is handled for this case in App.test.js 2 - Seeing cases where this test can fail due to getting state from the previous test (i.e. it will pass if run alone, fail bc gets expected result from above if not). Apparently this is a known issue with some weird troubleshooting: https://github.com/testing-library/react-testing-library/issues/716 imo the solution is to avoid testing the hook when you can better test the app. same is true for many of the tests here. These and those in useWallet.test.js should be moved to app.test.js. will do this incrementally.