Page MenuHomePhabricator

[depends] allow NO_OPENSSL=1
ClosedPublic

Authored by PiRK on Feb 28 2024, 10:39.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCa380f7fe0042: [depends] allow NO_OPENSSL=1
Summary

OpenSSL is not needed when BIP70 is disabled so this allows skipping the compilation during cross-building, which is useful for testing if a crossbuild issue is specifically caused by this lib.

Test Plan
make -C depends HOST="x86_64-linux-gnu" NO_OPENSSL=1
make -C depends HOST="x86_64-apple-darwin" NO_OPENSSL=1
make -C depends HOST="x86_64-w64-mingw32" NO_OPENSSL=1

Check that the gitian builds still work with the qt.mk changes.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

@bot gitian-osx gitian-linux gitian-win

Tail of the build log:

 * [new tag]             phabricator/diff/45512 -> phabricator/diff/45512
 * [new tag]             phabricator/diff/45515 -> phabricator/diff/45515
 * [new tag]             phabricator/diff/45528 -> phabricator/diff/45528
 * [new tag]             phabricator/diff/45534 -> phabricator/diff/45534
 * [new tag]             phabricator/diff/45548 -> phabricator/diff/45548
 * [new tag]             phabricator/diff/45564 -> phabricator/diff/45564
 * [new tag]             phabricator/diff/45565 -> phabricator/diff/45565
 * [new tag]             phabricator/diff/45566 -> phabricator/diff/45566
 * [new tag]             phabricator/diff/45573 -> phabricator/diff/45573
 * [new tag]             phabricator/diff/45584 -> phabricator/diff/45584
 * [new tag]             phabricator/diff/45585 -> phabricator/diff/45585
 * [new tag]             phabricator/diff/45595 -> phabricator/diff/45595
 * [new tag]             phabricator/diff/45597 -> phabricator/diff/45597
 * [new tag]             phabricator/diff/45600 -> phabricator/diff/45600
 * [new tag]             phabricator/diff/45601 -> phabricator/diff/45601
 * [new tag]             phabricator/diff/45602 -> phabricator/diff/45602
 * [new tag]             phabricator/diff/45603 -> phabricator/diff/45603
 * [new tag]             phabricator/diff/45612 -> phabricator/diff/45612
 * [new tag]             phabricator/diff/45620 -> phabricator/diff/45620
 * [new tag]             phabricator/diff/45621 -> phabricator/diff/45621
 * [new tag]             phabricator/diff/45624 -> phabricator/diff/45624
 * [new tag]             phabricator/diff/45626 -> phabricator/diff/45626
 * [new tag]             phabricator/diff/45641 -> phabricator/diff/45641
 * [new tag]             phabricator/diff/45643 -> phabricator/diff/45643
 * [new tag]             phabricator/diff/45644 -> phabricator/diff/45644
 * [new tag]             phabricator/diff/45645 -> phabricator/diff/45645
 * [new tag]             phabricator/diff/45647 -> phabricator/diff/45647
 * [new tag]             phabricator/diff/45650 -> phabricator/diff/45650
 * [new tag]             phabricator/diff/45652 -> phabricator/diff/45652
 * [new tag]             phabricator/diff/45666 -> phabricator/diff/45666
 * [new tag]             phabricator/diff/45672 -> phabricator/diff/45672
 * [new tag]             phabricator/diff/45673 -> phabricator/diff/45673
 * [new tag]             phabricator/diff/45674 -> phabricator/diff/45674
 * [new tag]             phabricator/diff/45694 -> phabricator/diff/45694
 * [new tag]             phabricator/diff/45697 -> phabricator/diff/45697
 * [new tag]             phabricator/diff/8992  -> phabricator/diff/8992
 * [new tag]             phabricator/diff/8993  -> phabricator/diff/8993
 * [new branch]          master                 -> master
--- Building for bullseye amd64 ---
Stopping target if it is up
Error response from daemon: No such container: gitian-target
Error: No such container: gitian-target
Making a new image copy
Starting target
Checking if target is up.
Preparing build environment
Updating apt-get repository (log in var/install.log)
Installing additional packages (log in var/install.log)
Upgrading system, may take a while (log in var/install.log)
Creating package manifest
Creating build script (var/build-script)
Running build script (log in var/build.log)
./bin/gbuild:23:in `system!': failed to run on-target setarch x86_64 bash -x < var/build-script > var/build.log 2>&1 (RuntimeError)
	from ./bin/gbuild:185:in `build_one_configuration'
	from ./bin/gbuild:339:in `block (2 levels) in <main>'
	from ./bin/gbuild:334:in `each'
	from ./bin/gbuild:334:in `block in <main>'
	from ./bin/gbuild:332:in `each'
	from ./bin/gbuild:332:in `<main>'
Build gitian-win failed with exit code 1

Tail of the build log:

 * [new tag]             phabricator/diff/45598 -> phabricator/diff/45598
 * [new tag]             phabricator/diff/45600 -> phabricator/diff/45600
 * [new tag]             phabricator/diff/45601 -> phabricator/diff/45601
 * [new tag]             phabricator/diff/45602 -> phabricator/diff/45602
 * [new tag]             phabricator/diff/45603 -> phabricator/diff/45603
 * [new tag]             phabricator/diff/45604 -> phabricator/diff/45604
 * [new tag]             phabricator/diff/45620 -> phabricator/diff/45620
 * [new tag]             phabricator/diff/45628 -> phabricator/diff/45628
 * [new tag]             phabricator/diff/45630 -> phabricator/diff/45630
 * [new tag]             phabricator/diff/45631 -> phabricator/diff/45631
 * [new tag]             phabricator/diff/45633 -> phabricator/diff/45633
 * [new tag]             phabricator/diff/45634 -> phabricator/diff/45634
 * [new tag]             phabricator/diff/45635 -> phabricator/diff/45635
 * [new tag]             phabricator/diff/45636 -> phabricator/diff/45636
 * [new tag]             phabricator/diff/45637 -> phabricator/diff/45637
 * [new tag]             phabricator/diff/45641 -> phabricator/diff/45641
 * [new tag]             phabricator/diff/45642 -> phabricator/diff/45642
 * [new tag]             phabricator/diff/45643 -> phabricator/diff/45643
 * [new tag]             phabricator/diff/45644 -> phabricator/diff/45644
 * [new tag]             phabricator/diff/45646 -> phabricator/diff/45646
 * [new tag]             phabricator/diff/45647 -> phabricator/diff/45647
 * [new tag]             phabricator/diff/45648 -> phabricator/diff/45648
 * [new tag]             phabricator/diff/45650 -> phabricator/diff/45650
 * [new tag]             phabricator/diff/45651 -> phabricator/diff/45651
 * [new tag]             phabricator/diff/45668 -> phabricator/diff/45668
 * [new tag]             phabricator/diff/45670 -> phabricator/diff/45670
 * [new tag]             phabricator/diff/45671 -> phabricator/diff/45671
 * [new tag]             phabricator/diff/45672 -> phabricator/diff/45672
 * [new tag]             phabricator/diff/45675 -> phabricator/diff/45675
 * [new tag]             phabricator/diff/45677 -> phabricator/diff/45677
 * [new tag]             phabricator/diff/45678 -> phabricator/diff/45678
 * [new tag]             phabricator/diff/45679 -> phabricator/diff/45679
 * [new tag]             phabricator/diff/45690 -> phabricator/diff/45690
 * [new tag]             phabricator/diff/45692 -> phabricator/diff/45692
 * [new tag]             phabricator/diff/45694 -> phabricator/diff/45694
 * [new tag]             phabricator/diff/45695 -> phabricator/diff/45695
 * [new tag]             phabricator/diff/45697 -> phabricator/diff/45697
 * [new tag]             phabricator/diff/8992  -> phabricator/diff/8992
 * [new tag]             phabricator/diff/8993  -> phabricator/diff/8993
 * [new branch]          master                 -> master
--- Building for bullseye amd64 ---
Stopping target if it is up
Making a new image copy
Starting target
Checking if target is up.
Preparing build environment
Updating apt-get repository (log in var/install.log)
Installing additional packages (log in var/install.log)
Upgrading system, may take a while (log in var/install.log)
Creating package manifest
Creating build script (var/build-script)
Running build script (log in var/build.log)
./bin/gbuild:23:in `system!': failed to run on-target setarch x86_64 bash -x < var/build-script > var/build.log 2>&1 (RuntimeError)
	from ./bin/gbuild:185:in `build_one_configuration'
	from ./bin/gbuild:339:in `block (2 levels) in <main>'
	from ./bin/gbuild:334:in `each'
	from ./bin/gbuild:334:in `block in <main>'
	from ./bin/gbuild:332:in `each'
	from ./bin/gbuild:332:in `<main>'
Build gitian-osx failed with exit code 1

Tail of the build log:

 * [new tag]             phabricator/diff/45423 -> phabricator/diff/45423
 * [new tag]             phabricator/diff/45434 -> phabricator/diff/45434
 * [new tag]             phabricator/diff/45435 -> phabricator/diff/45435
 * [new tag]             phabricator/diff/45448 -> phabricator/diff/45448
 * [new tag]             phabricator/diff/45451 -> phabricator/diff/45451
 * [new tag]             phabricator/diff/45452 -> phabricator/diff/45452
 * [new tag]             phabricator/diff/45454 -> phabricator/diff/45454
 * [new tag]             phabricator/diff/45455 -> phabricator/diff/45455
 * [new tag]             phabricator/diff/45459 -> phabricator/diff/45459
 * [new tag]             phabricator/diff/45472 -> phabricator/diff/45472
 * [new tag]             phabricator/diff/45473 -> phabricator/diff/45473
 * [new tag]             phabricator/diff/45517 -> phabricator/diff/45517
 * [new tag]             phabricator/diff/45519 -> phabricator/diff/45519
 * [new tag]             phabricator/diff/45527 -> phabricator/diff/45527
 * [new tag]             phabricator/diff/45533 -> phabricator/diff/45533
 * [new tag]             phabricator/diff/45535 -> phabricator/diff/45535
 * [new tag]             phabricator/diff/45548 -> phabricator/diff/45548
 * [new tag]             phabricator/diff/45564 -> phabricator/diff/45564
 * [new tag]             phabricator/diff/45565 -> phabricator/diff/45565
 * [new tag]             phabricator/diff/45566 -> phabricator/diff/45566
 * [new tag]             phabricator/diff/45568 -> phabricator/diff/45568
 * [new tag]             phabricator/diff/45577 -> phabricator/diff/45577
 * [new tag]             phabricator/diff/45602 -> phabricator/diff/45602
 * [new tag]             phabricator/diff/45612 -> phabricator/diff/45612
 * [new tag]             phabricator/diff/45615 -> phabricator/diff/45615
 * [new tag]             phabricator/diff/45620 -> phabricator/diff/45620
 * [new tag]             phabricator/diff/45621 -> phabricator/diff/45621
 * [new tag]             phabricator/diff/45626 -> phabricator/diff/45626
 * [new tag]             phabricator/diff/45628 -> phabricator/diff/45628
 * [new tag]             phabricator/diff/45648 -> phabricator/diff/45648
 * [new tag]             phabricator/diff/45653 -> phabricator/diff/45653
 * [new tag]             phabricator/diff/45655 -> phabricator/diff/45655
 * [new tag]             phabricator/diff/45666 -> phabricator/diff/45666
 * [new tag]             phabricator/diff/45672 -> phabricator/diff/45672
 * [new tag]             phabricator/diff/45697 -> phabricator/diff/45697
 * [new tag]             phabricator/diff/8992  -> phabricator/diff/8992
 * [new tag]             phabricator/diff/8993  -> phabricator/diff/8993
 * [new branch]          master                 -> master
--- Building for bullseye amd64 ---
Stopping target if it is up
Error response from daemon: No such container: gitian-target
Error: No such container: gitian-target
Making a new image copy
Starting target
Checking if target is up.
Preparing build environment
Updating apt-get repository (log in var/install.log)
Installing additional packages (log in var/install.log)
Upgrading system, may take a while (log in var/install.log)
Creating package manifest
Creating build script (var/build-script)
Running build script (log in var/build.log)
./bin/gbuild:23:in `system!': failed to run on-target setarch x86_64 bash -x < var/build-script > var/build.log 2>&1 (RuntimeError)
	from ./bin/gbuild:185:in `build_one_configuration'
	from ./bin/gbuild:339:in `block (2 levels) in <main>'
	from ./bin/gbuild:334:in `each'
	from ./bin/gbuild:334:in `block in <main>'
	from ./bin/gbuild:332:in `each'
	from ./bin/gbuild:332:in `<main>'
Build gitian-linux failed with exit code 1

@bot gitian-osx gitian-linux gitian-win

PiRK published this revision for review.Feb 28 2024, 12:52
This revision is now accepted and ready to land.Feb 28 2024, 13:47
This revision was automatically updated to reflect the committed changes.