Page MenuHomePhabricator

misc cleanups for symbol-check
ClosedPublic

Authored by PiRK on Feb 29 2024, 10:17.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCaebc9bda60bf: misc cleanups for symbol-check
Summary

Remove no longer needed Xenial related symbols.

The other change is a follow-up to D13971 and D13892: check_PE_subsystem_version does not take filename as an argument, and the current code only works by accident, because filename happens to be defined to the correct value in the outer scope when this function is called.

This is partially a backport of core#25392

Test Plan

gitian builds
contrib/guix/guix-build

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK requested review of this revision.Feb 29 2024, 10:17

@bot gitian-osx gitian-win gitian-linux

PiRK planned changes to this revision.Feb 29 2024, 10:21

I need to test whether we can also include https://github.com/bitcoin/bitcoin/pull/25392 in this

@bot gitian-linux

This revision is now accepted and ready to land.Feb 29 2024, 15:26
This revision was automatically updated to reflect the committed changes.