Page MenuHomePhabricator

[cmake] Ignore empty directories during source packaging
ClosedPublic

Authored by Fabien on Mar 6 2024, 07:32.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABC9d1c3afc5ebb: [cmake] Ignore empty directories during source packaging
Summary

The patterns from the .gitignore file are excluded from the source package, but directory exclusions (like output/) will leave an empty directory in the source package.
This diff fixes this by removing the directory as well.
Also add the distsrc directories to the ignored files so guix source package is clean.

Test Plan

Run the guix build twice and check the source package hash is deterministic.
Open the source package archive and check it is as expected.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien requested review of this revision.Mar 6 2024, 07:32
PiRK added a subscriber: PiRK.
PiRK added inline comments.
contrib/guix/libexec/build.sh
274 ↗(On Diff #45959)

restore blank line

This revision is now accepted and ready to land.Mar 6 2024, 08:02

Exclude guix files, fix newline

PiRK added inline comments.
cmake/modules/PackageHelper.cmake
60 ↗(On Diff #45962)

weird indentation