Differential D15645

[guix] Make the OSX DMG generation with xorrisofs deterministic
ClosedPublic
Actions

Authored by Fabien on Mar 6 2024, 13:58.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABCafd1f9497224: [guix] Make the OSX DMG generation with xorrisofs deterministic

Summary

If the SOURCE_DATE_EPOCH environment variable is set, use it.

Partial backport of core#17920:
https://github.com/bitcoin/bitcoin/pull/17920/commits/f3835dc6a3732dcd4afbb5987f84dc27f2bf55af

Test Plan

Run twice:

HOSTS="x86_64-apple-darwin" ./contrib/guix/guix-build

Check the hashes are identical

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Mar 6 2024, 13:58

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 6 2024, 13:58

Fabien requested review of this revision.Mar 6 2024, 13:58

teamcity edited the summary of this revision. (Show Details)Mar 6 2024, 13:58

PiRK accepted this revision.Mar 6 2024, 14:07

This revision is now accepted and ready to land.Mar 6 2024, 14:07

Harbormaster completed remote builds in B27697: Diff 45971.Mar 6 2024, 14:32

Closed by commit rABCafd1f9497224: [guix] Make the OSX DMG generation with xorrisofs deterministic (authored by Fabien). · Explain WhyMar 6 2024, 14:55

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCafd1f9497224: [guix] Make the OSX DMG generation with xorrisofs deterministic.

Revision Contents
Changeset List

Path

Size

src/

qt/

CMakeLists.txt

5 lines

Diff 45973

View Options

[guix] Make the OSX DMG generation with xorrisofs deterministicClosedPublicActions