Differential D15843

[avalanche] Fix a race in abc_p2p_avalanche_remote_proofs.py
ClosedPublic
Actions

Authored by Fabien on Apr 1 2024, 16:24.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC1efdb388195f: [avalanche] Fix a race in abc_p2p_avalanche_remote_proofs.py

Summary

The compact proofs are sent periodically so it's possible for the trigger_avaproofs() function to return on a previously sent message and cause the test to fail. This diff addresses this by using a retry loop and checking the last_update time to make sure we're looking at the correct message.

Test Plan

./test/functional/test_runner.py abc_p2p_avalanche_remote_proofs

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Apr 1 2024, 16:24

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 1 2024, 16:24

Fabien requested review of this revision.Apr 1 2024, 16:24

Harbormaster completed remote builds in B28233: Diff 46697.Apr 1 2024, 16:45

PiRK accepted this revision.Apr 1 2024, 17:39

This revision is now accepted and ready to land.Apr 1 2024, 17:39

Closed by commit rABC1efdb388195f: [avalanche] Fix a race in abc_p2p_avalanche_remote_proofs.py (authored by Fabien). · Explain WhyApr 1 2024, 18:54

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC1efdb388195f: [avalanche] Fix a race in abc_p2p_avalanche_remote_proofs.py.

Revision Contents
Changeset List

Path

Size

test/

functional/

abc_p2p_avalanche_remote_proofs.py

20 lines

Diff 46699

View Options

test/functional/abc_p2p_avalanche_remote_proofs.py

[avalanche] Fix a race in abc_p2p_avalanche_remote_proofs.pyClosedPublicActions