Paths

Table of Contentst

Differential D15951

[Cashtab] Standardize svg icon buttons
ClosedPublic
Actions

Authored by bytesofman on Thu, Apr 11, 22:22.

Details

Reviewers

emack

Group Reviewers

Restricted Project

Commits

rABCd9d7b828d0ce: [Cashtab] Standardize svg icon buttons

Summary

T3528

Starting to implement NFTs in Cashtab -- requires a number of UI improvements. After the recent UI overhaul I would prefer to avoid tech debt as much as possible. So, there are some basic UI improvements to get in before building the NFT interface.

Here we standardize the icon button, a component that is re-used on different screens with different implementations.

Test Plan

npm test

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bytesofman created this revision.Thu, Apr 11, 22:22

Herald added a reviewer: Restricted Project. · View Herald TranscriptThu, Apr 11, 22:22

Harbormaster completed remote builds in B28493: Diff 47054.Thu, Apr 11, 22:25

add copy button tests, improve test query accessors

bytesofman published this revision for review.Thu, Apr 11, 22:41

Harbormaster completed remote builds in B28496: Diff 47057.Thu, Apr 11, 22:44

emack accepted this revision.Fri, Apr 12, 00:41

This revision is now accepted and ready to land.Fri, Apr 12, 00:41

Closed by commit rABCd9d7b828d0ce: [Cashtab] Standardize svg icon buttons (authored by bytesofman). · Explain WhyFri, Apr 12, 02:00

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABCd9d7b828d0ce: [Cashtab] Standardize svg icon buttons.

Revision Contents
Changeset List

Path

Size

cashtab/

package-lock.json

4 lines

package.json

2 lines

src/

components/

Airdrop/

Airdrop.js

2 lines

Alias/

Alias.js

2 lines

Common/

	Buttons.js
	PrimaryButton.js

81 lines

PrimaryButton.js

Contacts/

__tests__/

index.test.js

24 lines

index.js

42 lines

styles.js

11 lines

Etokens/

CreateTokenForm.js

2 lines

Etokens.js

2 lines

OnBoarding/

OnBoarding.js

4 lines

Send/

SendToken.js

4 lines

SendXec.js

2 lines

SignVerifyMsg/

SignVerifyMsg.js

4 lines

Swap/

Swap.js

2 lines

Wallets/

__tests__/

index.test.js

71 lines

index.js

62 lines

styles.js

11 lines

Diff 47074

View Options

cashtab/package-lock.json

View Options

cashtab/package.json

View Options

cashtab/src/components/Airdrop/Airdrop.js

View Options

cashtab/src/components/Alias/Alias.js

View Options

cashtab/src/components/Common/Buttons.js

View Options

cashtab/src/components/Common/PrimaryButton.js

View Options

cashtab/src/components/Contacts/tests/index.test.js

View Options

cashtab/src/components/Contacts/index.js

View Options

cashtab/src/components/Contacts/styles.js

View Options

cashtab/src/components/Etokens/CreateTokenForm.js

View Options

cashtab/src/components/Etokens/Etokens.js

View Options

cashtab/src/components/OnBoarding/OnBoarding.js

View Options

cashtab/src/components/Send/SendToken.js

View Options

cashtab/src/components/Send/SendXec.js

View Options

cashtab/src/components/SignVerifyMsg/SignVerifyMsg.js

View Options

cashtab/src/components/Swap/Swap.js

View Options

cashtab/src/components/Wallets/tests/index.test.js

View Options

cashtab/src/components/Wallets/index.js

View Options

cashtab/src/components/Wallets/styles.js

[Cashtab] Standardize svg icon buttonsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 47074

cashtab/package-lock.json

cashtab/package.json

cashtab/src/components/Airdrop/Airdrop.js

cashtab/src/components/Alias/Alias.js

cashtab/src/components/Common/Buttons.js

cashtab/src/components/Common/PrimaryButton.js

cashtab/src/components/Contacts/__tests__/index.test.js

cashtab/src/components/Contacts/index.js

cashtab/src/components/Contacts/styles.js

cashtab/src/components/Etokens/CreateTokenForm.js

cashtab/src/components/Etokens/Etokens.js

cashtab/src/components/OnBoarding/OnBoarding.js

cashtab/src/components/Send/SendToken.js

cashtab/src/components/Send/SendXec.js

cashtab/src/components/SignVerifyMsg/SignVerifyMsg.js

cashtab/src/components/Swap/Swap.js

cashtab/src/components/Wallets/__tests__/index.test.js

cashtab/src/components/Wallets/index.js

cashtab/src/components/Wallets/styles.js

[Cashtab] Standardize svg icon buttons
ClosedPublic
Actions

Revision Contents
Changeset List

cashtab/src/components/Contacts/tests/index.test.js

cashtab/src/components/Wallets/tests/index.test.js