Page MenuHomePhabricator
Differential D15971

[Cashtab] Fix svg icons
ClosedPublic
Actions

Authored by bytesofman on Apr 13 2024, 02:50.

Details

Reviewers
emack
Group Reviewers
Restricted Project
Commits
rABCcb8c60771483: [Cashtab] Fix svg icons
Summary

Fix missed badly implemented icons

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bytesofman created this revision.Apr 13 2024, 02:50
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 13 2024, 02:50
Harbormaster completed remote builds in B28541: Diff 47124.Apr 13 2024, 02:53
teamcity added a comment.Apr 13 2024, 02:53
Build Bitcoin ABC Diffs / Diff Testing (cashtab-tests) failed.

Failed tests logs:

====== CashTab Unit Tests: <Tx /> Sent encrypted msg ======
TestingLibraryElementError: Unable to find an element with the alt text: tx-encrypted-msg

Ignored nodes: comments, script, style
<body>
  <div>
    <div
      class="sc-bdVaJa jjgtxs"
    >
      <div
        class="sc-bwzfXH evareY"
      >
        <div
          class="sc-htpNat kSasoO"
          type="Sent"
        >
          <div
            class="sc-bxivhb cHJlww"
          >
            <div
              class="sc-jlyJG dofWdj"
            >
              <svg
                title="tx-sent"
              />
            </div>
            <div
              class="sc-EHOje eTNtAZ"
            >
              <div
                class="sc-bZQynM dcxKDB"
              >
                Sent
                 to
                <a
                  class="sc-cSHVUG hEetWT"
                  href="https://explorer.e.cash/address/ecash:qp89xgjhcqdnzzemts0aj378nfe2mhu9yvxj9nhgg6"
                  rel="noreferrer"
                  target="_blank"
                >
                  qp8...gg6
                </a>
              </div>
              <div
                class="sc-gzVnrw yuYHj"
              >
                Oct 4, 2022, 19:08:19
              </div>
            </div>
          </div>
          <div
            class="sc-htoDjs jPVHXc"
          >
            <div
              class="sc-dnqmqq erFPtP"
            >
              -
              12
               XEC
            </div>
            <div
              class="sc-iwsKbI dNxGoF"
            >
              -
              $
              0.00
            </div>
          </div>
        </div>
        <div
          class="sc-kAzzGY gQBcPu"
        >
          <div
            class="sc-kgoBCf gzfUiC"
          >
            <svg
              title="tx-encrypted-msg"
            />
            <div
              class="sc-chPdSV iBSOwa"
            >
              Encrypted Cashtab Msg
            </div>
          </div>
        </div>
      </div>
      <div
        class="sc-VigVT insgQP"
      >
        <div
          class="sc-fBuWsC cItAUD"
        >
          <button
            class="sc-jTzLTM fRsnRu"
          >
            <svg
              title="copy-paste"
            />
          </button>
        </div>
        <a
          class="sc-fjdhpX jThIck"
          href="https://explorer.e.cash/tx/7ac10096c8a7b32fe338dc938bcf2e1341b99f841687e690d88241107ce4b84b"
          rel="noreferrer"
          target="_blank"
        >
          <svg
            class="sc-hSdWYo jYVOlp"
          />
        </a>
        <a
          class="sc-fjdhpX jThIck"
          href="https://blockchair.com/ecash/transaction/7ac10096c8a7b32fe338dc938bcf2e1341b99f841687e690d88241107ce4b84b.pdf"
          rel="noreferrer"
          target="_blank"
        >
          <svg
            class="sc-eHgmQL gEiDmx"
          />
        </a>
        <button
          class="sc-jTzLTM fRsnRu"
        >
          <svg
            title="add-contact"
          />
        </button>
      </div>
    </div>
    ,
  </div>
</body>
    at Object.getElementError (/work/cashtab/node_modules/@testing-library/dom/dist/config.js:37:19)
    at /work/cashtab/node_modules/@testing-library/dom/dist/query-helpers.js:76:38
    at /work/cashtab/node_modules/@testing-library/dom/dist/query-helpers.js:52:17
    at /work/cashtab/node_modules/@testing-library/dom/dist/query-helpers.js:95:19
    at Object.getByAltText (/work/cashtab/src/components/Home/Tx/__tests__/index.test.js:954:23)
    at Promise.then.completed (/work/cashtab/node_modules/jest-circus/build/utils.js:298:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (/work/cashtab/node_modules/jest-circus/build/utils.js:231:10)
    at _callCircusTest (/work/cashtab/node_modules/jest-circus/build/run.js:316:40)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
    at _runTest (/work/cashtab/node_modules/jest-circus/build/run.js:252:3)
    at _runTestsForDescribeBlock (/work/cashtab/node_modules/jest-circus/build/run.js:126:9)
    at _runTestsForDescribeBlock (/work/cashtab/node_modules/jest-circus/build/run.js:121:9)
    at run (/work/cashtab/node_modules/jest-circus/build/run.js:71:3)
    at runAndTransformResultsToJestFormat (/work/cashtab/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at jestAdapter (/work/cashtab/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at runTestInternal (/work/cashtab/node_modules/jest-runner/build/runTest.js:367:16)
    at runTest (/work/cashtab/node_modules/jest-runner/build/runTest.js:444:34)
    at Object.worker (/work/cashtab/node_modules/jest-runner/build/testWorker.js:106:12)
====== CashTab Unit Tests: <Tx /> Received encrypted msg ======
TestingLibraryElementError: Unable to find an element with the alt text: tx-encrypted-msg

Ignored nodes: comments, script, style
<body>
  <div>
    <div
      class="sc-bdVaJa jjgtxs"
    >
      <div
        class="sc-bwzfXH evareY"
      >
        <div
          class="sc-htpNat fTPTBn"
          type="Received"
        >
          <div
            class="sc-bxivhb cHJlww"
          >
            <svg
              title="tx-received"
            />
            <div
              class="sc-EHOje eTNtAZ"
            >
              <div
                class="sc-bZQynM dcxKDB"
              >
                Received
                 from
                <a
                  class="sc-cSHVUG hEetWT"
                  href="https://explorer.e.cash/address/ecash:qp89xgjhcqdnzzemts0aj378nfe2mhu9yvxj9nhgg6"
                  rel="noreferrer"
                  target="_blank"
                >
                  qp8...gg6
                </a>
              </div>
              <div
                class="sc-gzVnrw yuYHj"
              >
                Oct 4, 2022, 19:08:19
              </div>
            </div>
          </div>
          <div
            class="sc-htoDjs jPVHXc"
          >
            <div
              class="sc-dnqmqq erFPtP"
            >
              11
               XEC
            </div>
            <div
              class="sc-iwsKbI dNxGoF"
            >
              $
              0.00
            </div>
          </div>
        </div>
        <div
          class="sc-kAzzGY gQBcPu"
        >
          <div
            class="sc-kgoBCf gzfUiC"
          >
            <svg
              title="tx-encrypted-msg"
            />
            <div
              class="sc-chPdSV iBSOwa"
            >
              Encrypted Cashtab Msg
            </div>
          </div>
        </div>
      </div>
      <div
        class="sc-VigVT insgQP"
      >
        <div
          class="sc-fBuWsC cItAUD"
        >
          <button
            class="sc-jTzLTM fRsnRu"
          >
            <svg
              title="copy-paste"
            />
          </button>
        </div>
        <a
          class="sc-fjdhpX jThIck"
          href="https://explorer.e.cash/tx/66974f4a22ca1a4aa36c932b4effafcb9dd8a32b8766dfc7644ba5922252c4c6"
          rel="noreferrer"
          target="_blank"
        >
          <svg
            class="sc-hSdWYo jYVOlp"
          />
        </a>
        <a
          class="sc-fjdhpX jThIck"
          href="https://blockchair.com/ecash/transaction/66974f4a22ca1a4aa36c932b4effafcb9dd8a32b8766dfc7644ba5922252c4c6.pdf"
          rel="noreferrer"
          target="_blank"
        >
          <svg
            class="sc-eHgmQL gEiDmx"
          />
        </a>
        <button
          class="sc-jTzLTM fRsnRu"
        >
          <svg
            title="add-contact"
          />
        </button>
      </div>
    </div>
    ,
  </div>
</body>
    at Object.getElementError (/work/cashtab/node_modules/@testing-library/dom/dist/config.js:37:19)
    at /work/cashtab/node_modules/@testing-library/dom/dist/query-helpers.js:76:38
    at /work/cashtab/node_modules/@testing-library/dom/dist/query-helpers.js:52:17
    at /work/cashtab/node_modules/@testing-library/dom/dist/query-helpers.js:95:19
    at Object.getByAltText (/work/cashtab/src/components/Home/Tx/__tests__/index.test.js:994:23)
    at Promise.then.completed (/work/cashtab/node_modules/jest-circus/build/utils.js:298:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (/work/cashtab/node_modules/jest-circus/build/utils.js:231:10)
    at _callCircusTest (/work/cashtab/node_modules/jest-circus/build/run.js:316:40)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
    at _runTest (/work/cashtab/node_modules/jest-circus/build/run.js:252:3)
    at _runTestsForDescribeBlock (/work/cashtab/node_modules/jest-circus/build/run.js:126:9)
    at _runTestsForDescribeBlock (/work/cashtab/node_modules/jest-circus/build/run.js:121:9)
    at run (/work/cashtab/node_modules/jest-circus/build/run.js:71:3)
    at runAndTransformResultsToJestFormat (/work/cashtab/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at jestAdapter (/work/cashtab/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at runTestInternal (/work/cashtab/node_modules/jest-runner/build/runTest.js:367:16)
    at runTest (/work/cashtab/node_modules/jest-runner/build/runTest.js:444:34)
    at Object.worker (/work/cashtab/node_modules/jest-runner/build/testWorker.js:106:12)
====== CashTab Unit Tests: <Tx /> eCash chat tx ======
TestingLibraryElementError: Unable to find an element with the alt text: tx-chat

Ignored nodes: comments, script, style
<body>
  <div>
    <div
      class="sc-bdVaJa jjgtxs"
    >
      <div
        class="sc-bwzfXH evareY"
      >
        <div
          class="sc-htpNat fTPTBn"
          type="Received"
        >
          <div
            class="sc-bxivhb cHJlww"
          >
            <svg
              title="tx-received"
            />
            <div
              class="sc-EHOje eTNtAZ"
            >
              <div
                class="sc-bZQynM dcxKDB"
              >
                Received
                 from
                <a
                  class="sc-cSHVUG hEetWT"
                  href="https://explorer.e.cash/address/ecash:qqznd7vug3avk24jdwgakaqewkmwp0vczu5u9man9y"
                  rel="noreferrer"
                  target="_blank"
                >
                  qqz...n9y
                </a>
              </div>
              <div
                class="sc-gzVnrw yuYHj"
              >
                Mar 30, 2024, 08:54:10
              </div>
            </div>
          </div>
          <div
            class="sc-htoDjs jPVHXc"
          >
            <div
              class="sc-dnqmqq erFPtP"
            >
              10
               XEC
            </div>
            <div
              class="sc-iwsKbI dNxGoF"
            >
              $
              0.00
            </div>
          </div>
        </div>
        <div
          class="sc-kAzzGY gQBcPu"
        >
          <div
            class="sc-kgoBCf gzfUiC"
          >
            <svg
              title="tx-chat"
            />
            <div
              class="sc-chPdSV iBSOwa"
            >
              eCash Chat
            </div>
          </div>
          <div
            class="sc-kGXeez iOcodC"
          >
            hello from eCash Chat   
          </div>
          <a
            class="sc-fjdhpX jThIck"
            href="/send"
          >
            <svg
              title="reply"
            />
          </a>
        </div>
      </div>
      <div
        class="sc-VigVT insgQP"
      >
        <div
          class="sc-fBuWsC cItAUD"
        >
          <button
            class="sc-jTzLTM fRsnRu"
          >
            <svg
              title="copy-paste"
            />
          </button>
        </div>
        <a
          class="sc-fjdhpX jThIck"
          href="https://explorer.e.cash/tx/a3b3e23eb564920c10b1b6278a1e00dcec0c8b1593fc0d7f2e514cf20416255c"
          rel="noreferrer"
          target="_blank"
        >
          <svg
            class="sc-hSdWYo jYVOlp"
          />
        </a>
        <a
          class="sc-fjdhpX jThIck"
          href="https://blockchair.com/ecash/transaction/a3b3e23eb564920c10b1b6278a1e00dcec0c8b1593fc0d7f2e514cf20416255c.pdf"
          rel="noreferrer"
          target="_blank"
        >
          <svg
            class="sc-eHgmQL gEiDmx"
          />
        </a>
        <button
          class="sc-jTzLTM fRsnRu"
        >
          <svg
            title="add-contact"
          />
        </button>
      </div>
    </div>
    ,
  </div>
</body>
    at Object.getElementError (/work/cashtab/node_modules/@testing-library/dom/dist/config.js:37:19)
    at /work/cashtab/node_modules/@testing-library/dom/dist/query-helpers.js:76:38
    at /work/cashtab/node_modules/@testing-library/dom/dist/query-helpers.js:52:17
    at /work/cashtab/node_modules/@testing-library/dom/dist/query-helpers.js:95:19
    at Object.getByAltText (/work/cashtab/src/components/Home/Tx/__tests__/index.test.js:1496:23)
    at Promise.then.completed (/work/cashtab/node_modules/jest-circus/build/utils.js:298:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (/work/cashtab/node_modules/jest-circus/build/utils.js:231:10)
    at _callCircusTest (/work/cashtab/node_modules/jest-circus/build/run.js:316:40)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
    at _runTest (/work/cashtab/node_modules/jest-circus/build/run.js:252:3)
    at _runTestsForDescribeBlock (/work/cashtab/node_modules/jest-circus/build/run.js:126:9)
    at _runTestsForDescribeBlock (/work/cashtab/node_modules/jest-circus/build/run.js:121:9)
    at run (/work/cashtab/node_modules/jest-circus/build/run.js:71:3)
    at runAndTransformResultsToJestFormat (/work/cashtab/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at jestAdapter (/work/cashtab/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at runTestInternal (/work/cashtab/node_modules/jest-runner/build/runTest.js:367:16)
    at runTest (/work/cashtab/node_modules/jest-runner/build/runTest.js:444:34)
    at Object.worker (/work/cashtab/node_modules/jest-runner/build/testWorker.js:106:12)
====== CashTab Unit Tests: <Tx /> off-spec eCash chat tx ======
TestingLibraryElementError: Unable to find an element with the alt text: tx-chat

Ignored nodes: comments, script, style
<body>
  <div>
    <div
      class="sc-bdVaJa jjgtxs"
    >
      <div
        class="sc-bwzfXH evareY"
      >
        <div
          class="sc-htpNat fTPTBn"
          type="Received"
        >
          <div
            class="sc-bxivhb cHJlww"
          >
            <svg
              title="tx-received"
            />
            <div
              class="sc-EHOje eTNtAZ"
            >
              <div
                class="sc-bZQynM dcxKDB"
              >
                Received
                 from
                <a
                  class="sc-cSHVUG hEetWT"
                  href="https://explorer.e.cash/address/ecash:qqznd7vug3avk24jdwgakaqewkmwp0vczu5u9man9y"
                  rel="noreferrer"
                  target="_blank"
                >
                  qqz...n9y
                </a>
              </div>
              <div
                class="sc-gzVnrw yuYHj"
              >
                Mar 30, 2024, 08:54:10
              </div>
            </div>
          </div>
          <div
            class="sc-htoDjs jPVHXc"
          >
            <div
              class="sc-dnqmqq erFPtP"
            >
              10
               XEC
            </div>
            <div
              class="sc-iwsKbI dNxGoF"
            >
              $
              0.00
            </div>
          </div>
        </div>
        <div
          class="sc-kAzzGY gQBcPu"
        >
          <div
            class="sc-kgoBCf gzfUiC"
          >
            <svg
              title="tx-chat"
            />
            <div
              class="sc-chPdSV iBSOwa"
            >
              Invalid eCash Chat
            </div>
          </div>
        </div>
      </div>
      <div
        class="sc-VigVT insgQP"
      >
        <div
          class="sc-fBuWsC cItAUD"
        >
          <button
            class="sc-jTzLTM fRsnRu"
          >
            <svg
              title="copy-paste"
            />
          </button>
        </div>
        <a
          class="sc-fjdhpX jThIck"
          href="https://explorer.e.cash/tx/a3b3e23eb564920c10b1b6278a1e00dcec0c8b1593fc0d7f2e514cf20416255c"
          rel="noreferrer"
          target="_blank"
        >
          <svg
            class="sc-hSdWYo jYVOlp"
          />
        </a>
        <a
          class="sc-fjdhpX jThIck"
          href="https://blockchair.com/ecash/transaction/a3b3e23eb564920c10b1b6278a1e00dcec0c8b1593fc0d7f2e514cf20416255c.pdf"
          rel="noreferrer"
          target="_blank"
        >
          <svg
            class="sc-eHgmQL gEiDmx"
          />
        </a>
        <button
          class="sc-jTzLTM fRsnRu"
        >
          <svg
            title="add-contact"
          />
        </button>
      </div>
    </div>
    ,
  </div>
</body>
    at Object.getElementError (/work/cashtab/node_modules/@testing-library/dom/dist/config.js:37:19)
    at /work/cashtab/node_modules/@testing-library/dom/dist/query-helpers.js:76:38
    at /work/cashtab/node_modules/@testing-library/dom/dist/query-helpers.js:52:17
    at /work/cashtab/node_modules/@testing-library/dom/dist/query-helpers.js:95:19
    at Object.getByAltText (/work/cashtab/src/components/Home/Tx/__tests__/index.test.js:1550:23)
    at Promise.then.completed (/work/cashtab/node_modules/jest-circus/build/utils.js:298:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (/work/cashtab/node_modules/jest-circus/build/utils.js:231:10)
    at _callCircusTest (/work/cashtab/node_modules/jest-circus/build/run.js:316:40)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
    at _runTest (/work/cashtab/node_modules/jest-circus/build/run.js:252:3)
    at _runTestsForDescribeBlock (/work/cashtab/node_modules/jest-circus/build/run.js:126:9)
    at _runTestsForDescribeBlock (/work/cashtab/node_modules/jest-circus/build/run.js:121:9)
    at run (/work/cashtab/node_modules/jest-circus/build/run.js:71:3)
    at runAndTransformResultsToJestFormat (/work/cashtab/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at jestAdapter (/work/cashtab/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at runTestInternal (/work/cashtab/node_modules/jest-runner/build/runTest.js:367:16)
    at runTest (/work/cashtab/node_modules/jest-runner/build/runTest.js:444:34)
    at Object.worker (/work/cashtab/node_modules/jest-runner/build/testWorker.js:106:12)

Each failure log is accessible here:
CashTab Unit Tests: <Tx /> Sent encrypted msg
CashTab Unit Tests: <Tx /> Received encrypted msg
CashTab Unit Tests: <Tx /> eCash chat tx
CashTab Unit Tests: <Tx /> off-spec eCash chat tx

bytesofman updated this revision to Diff 47125.Apr 13 2024, 02:54

update tests for title instead of alt

bytesofman published this revision for review.Apr 13 2024, 02:56
Harbormaster completed remote builds in B28542: Diff 47125.Apr 13 2024, 03:15
emack accepted this revision.Apr 13 2024, 10:16
This revision is now accepted and ready to land.Apr 13 2024, 10:16
Closed by commit rABCcb8c60771483: [Cashtab] Fix svg icons (authored by bytesofman). · Explain WhyApr 13 2024, 13:37
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABCcb8c60771483: [Cashtab] Fix svg icons.

Revision Contents
Changeset List

PathSize
cashtab/
extension/
public/
2 lines
4 lines
2 lines
src/
components/
Common/
4 lines
Home/
Tx/
__tests__/
8 lines

Diff 47133

View Options

cashtab/extension/public/manifest.json

Loading...
View Options

cashtab/package-lock.json

Loading...
View Options

cashtab/package.json

Loading...
View Options

cashtab/src/components/Common/CustomIcons.js

Loading...
View Options

cashtab/src/components/Home/Tx/__tests__/index.test.js

Loading...