Paths

Table of Contentst

Differential D15985

[Cashtab] Do not render reply option to eCash chat
ClosedPublic
Actions

Authored by bytesofman on Mon, Apr 15, 21:37.

Details

Reviewers

emack

Group Reviewers

Restricted Project

Commits

rABC83c85b7f05cd: [Cashtab] Do not render reply option to eCash chat

Summary

T3540

Cashtab does not support replying to an ecash chat with an on-spec ecash chat. It does not make sense for 'reply' to take the user to sending a Cashtab Msg to the eCash chat sender (current behavior).

So, do not render a reply button for received eCash chat.

Test Plan

npm test

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bytesofman created this revision.Mon, Apr 15, 21:37

Herald added a reviewer: Restricted Project. · View Herald TranscriptMon, Apr 15, 21:37

bytesofman published this revision for review.Mon, Apr 15, 21:37

Harbormaster completed remote builds in B28582: Diff 47177.Mon, Apr 15, 21:40

emack accepted this revision.Tue, Apr 16, 00:31

This revision is now accepted and ready to land.Tue, Apr 16, 00:31

Closed by commit rABC83c85b7f05cd: [Cashtab] Do not render reply option to eCash chat (authored by bytesofman). · Explain WhyTue, Apr 16, 01:01

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABC83c85b7f05cd: [Cashtab] Do not render reply option to eCash chat.

Revision Contents
Changeset List

Path

Size

cashtab/

package-lock.json

4 lines

package.json

2 lines

src/

components/

Home/

Tx/

__tests__/

index.test.js

6 lines

index.js

11 lines

Diff 47185

View Options

cashtab/package-lock.json

View Options

cashtab/package.json

View Options

cashtab/src/components/Home/Tx/tests/index.test.js

View Options

cashtab/src/components/Home/Tx/index.js

[Cashtab] Do not render reply option to eCash chatClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 47185

cashtab/package-lock.json

cashtab/package.json

cashtab/src/components/Home/Tx/__tests__/index.test.js

cashtab/src/components/Home/Tx/index.js

[Cashtab] Do not render reply option to eCash chat
ClosedPublic
Actions

Revision Contents
Changeset List

cashtab/src/components/Home/Tx/tests/index.test.js