Differential D15994

[e.cash] Build page updates
ClosedPublic
Actions

Authored by johnkuney on Apr 16 2024, 17:27.

Details

Reviewers

bytesofman

Group Reviewers

Restricted Project

Commits

rABCe61d75346f76: [e.cash] Build page updates

Summary

Proposed improvments to /build page style and maintainablity

Moving some copy from the top section below the fold as was a lot and causing overflow issues
Styling the links a bit more
Move the info to an array and mapping over it instead to easily add or remove items

Test Plan

Preview the site and check /build

Diff Detail

Repository

rABC Bitcoin ABC

Branch

ecash-UPDATE-DEVLEOPER-PAGE

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 28604
Build 56749: Build Diff
Build 56748: arc lint + arc unit

Event Timeline

johnkuney created this revision.Apr 16 2024, 17:27

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 16 2024, 17:27

johnkuney requested review of this revision.Apr 16 2024, 17:27

Harbormaster completed remote builds in B28600: Diff 47207.Apr 16 2024, 17:28

@bot preview-e.cash

Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://54.39.104.128:41679 for the next 60 minutes.

Practical to add a "coming soon" section? For now, contents would be

ecash-lib
Full-feature ecash native tx building

and it would not be a link

bytesofman requested changes to this revision.Apr 16 2024, 18:06

bytesofman added inline comments.

web/e.cash/pages/build.js
98–102 ↗	(On Diff #47207)

This revision now requires changes to proceed.Apr 16 2024, 18:06

copy edit
add coming soon

Harbormaster completed remote builds in B28604: Diff 47212.Apr 16 2024, 20:43

@bot preview-e.cash

Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://54.39.19.73:41637 for the next 60 minutes.

bytesofman accepted this revision.Apr 16 2024, 21:00

This revision is now accepted and ready to land.Apr 16 2024, 21:00

Closed by commit rABCe61d75346f76: [e.cash] Build page updates (authored by johnkuney). · Explain WhyApr 17 2024, 00:19

This revision was automatically updated to reflect the committed changes.

johnkuney added a commit: rABCe61d75346f76: [e.cash] Build page updates.

Revision Contents
Changeset List

Path

Size

web/

e.cash/

pages/

build.js

227 lines

styles/

pages/

build.js

94 lines

Diff 47212

View Options

web/e.cash/pages/build.js