Differential D16089

Fix an off by one index error in makeseeds.py
ClosedPublic
Actions

Authored by Fabien on May 1 2024, 07:23.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABCe21337ab96f7: Fix an off by one index error in makeseeds.py

Summary

Each line of the dnsseed.dump contains at least 12 items so we assert the length then access indexes 0 to 11. The assertion is off by one.

Test Plan

Run the makeseeds.py against a dnsseed.dump that is missing the user agent string and check it doesn't crash.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.May 1 2024, 07:23

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 1 2024, 07:23

Fabien requested review of this revision.May 1 2024, 07:23

Harbormaster completed remote builds in B28836: Diff 47541.May 1 2024, 07:23

PiRK accepted this revision.May 1 2024, 11:31

This revision is now accepted and ready to land.May 1 2024, 11:31

Closed by commit rABCe21337ab96f7: Fix an off by one index error in makeseeds.py (authored by Fabien). · Explain WhyMay 1 2024, 11:36

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCe21337ab96f7: Fix an off by one index error in makeseeds.py.

Revision Contents
Changeset List

Path

Size

contrib/

seeds/

makeseeds.py

2 lines

Diff 47542

View Options

contrib/seeds/makeseeds.py

Fix an off by one index error in makeseeds.pyClosedPublicActions