Page MenuHomePhabricator
Differential D16108

move DummyConfig to test/util/setup_common.h
ClosedPublic
Actions

Authored by PiRK on Fri, May 3, 16:26.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC7eb1a738fe5d: move DummyConfig to test/util/setup_common.h
Summary

This is a test only class, so it makes sense to have it defined in the test directory.

In a following commit, I want to add an ArgsManager argument for CreateChainParams, and this will avoid having to couple config.h/cpp with the ArgsManager (system.h). This is needed for decoupling CChainParams and ArgsManager in future Core backports.

Test Plan

ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Fri, May 3, 16:26
Herald added a reviewer: Restricted Project. · View Herald TranscriptFri, May 3, 16:26
PiRK requested review of this revision.Fri, May 3, 16:26
PiRK edited the summary of this revision. (Show Details)Fri, May 3, 16:28
Harbormaster completed remote builds in B28881: Diff 47603.Fri, May 3, 16:48
Fabien accepted this revision.Mon, May 6, 08:11
Fabien edited the summary of this revision. (Show Details)
This revision is now accepted and ready to land.Mon, May 6, 08:12
Closed by commit rABC7eb1a738fe5d: move DummyConfig to test/util/setup_common.h (authored by PiRK). · Explain WhyMon, May 6, 14:14
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC7eb1a738fe5d: move DummyConfig to test/util/setup_common.h.

Revision Contents
Changeset List

PathSize
src/
17 lines
6 lines
qt/
test/
2 lines
test/
util/
17 lines
6 lines

Diff 47644

View Options

src/config.h

Loading...
View Options

src/config.cpp

Loading...
View Options

src/qt/test/guiutiltests.cpp

Loading...
View Options

src/test/util/setup_common.h

Loading...
View Options

src/test/util/setup_common.cpp

Loading...