Page MenuHomePhabricator

move DummyConfig to test/util/setup_common.h
ClosedPublic

Authored by PiRK on May 3 2024, 16:26.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC7eb1a738fe5d: move DummyConfig to test/util/setup_common.h
Summary

This is a test only class, so it makes sense to have it defined in the test directory.

In a following commit, I want to add an ArgsManager argument for CreateChainParams, and this will avoid having to couple config.h/cpp with the ArgsManager (system.h). This is needed for decoupling CChainParams and ArgsManager in future Core backports.

Test Plan

ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK requested review of this revision.May 3 2024, 16:26
Fabien edited the summary of this revision. (Show Details)
This revision is now accepted and ready to land.May 6 2024, 08:12
This revision was automatically updated to reflect the committed changes.