Page MenuHomePhabricator

[e.cash] Fix mobile video display issue
ClosedPublic

Authored by johnkuney on May 3 2024, 19:21.

Details

Reviewers
bytesofman
Group Reviewers
Restricted Project
Commits
rABC7bc682f5d5e1: [e.cash] Fix mobile video display issue
Summary

Some users are seeing the background video jump to full screen on mobile causing bad UX and sometimes a blank screen effect.
For example on /build, /roadmap, /get-ecash
It seems to be unique to iOS safari which has an autoplay fullscreen feature in it apparently
Even setting the video to display none the issue persisted, so opting to conditionally render the video based on screen size and show a still frame on mobile
The video playback speed is a relic of the stealthmode theme, and the ref was causing some issues here when conditionally rendering so also taking that out here

Test Plan

Preview the site and check some subpages out to see if any display issues happen on mobile

Diff Detail

Repository
rABC Bitcoin ABC
Branch
ecash-mobile-glitch-fix
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 28883
Build 57304: Build Diff
Build 57303: arc lint + arc unit

Event Timeline

@bot preview-e.cash

remove video from DOM on mobile

johnkuney retitled this revision from [e.cash] Fix mobile display issue on subpages to [e.cash] Fix mobile video display issue.May 3 2024, 20:36
johnkuney edited the summary of this revision. (Show Details)
johnkuney edited the test plan for this revision. (Show Details)
This revision is now accepted and ready to land.May 3 2024, 23:17
This revision was automatically updated to reflect the committed changes.