Page MenuHomePhabricator
Differential D16124

Split non/kernel chainparams
ClosedPublic
Actions

Authored by PiRK on Tue, May 7, 10:43.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC6807143b114f: Split non/kernel chainparams
Summary

Moves chainparams code not using the ArgsManager to the kernel.

Subsequently use the kernel chainparams header now where possible in order to further decouple chainparams call sites from gArgs.

Make it possible for the Config object to optionnaly own the chainparams ard return the member rather than the global chainparams, and demo it in bitcoin-chainstate.

Note that the new kernel/chainparams.cpp needs to be in the common lib (as opposed to the server lib that has all the other kernel/* components) for bitcoin-tx to not fail linking.

This concludes backport of core#26177
https://github.com/bitcoin/bitcoin/pull/26177/commits/382b692a503355df7347efd9c128aff465b5583e

Test Plan
cmake .. -GNinja -DBUILD_BITCOIN_CHAINSTATE=ON -DBUILD_BITCOIN_CHRONIK=ON
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Tue, May 7, 10:43
Herald added a reviewer: Restricted Project. · View Herald TranscriptTue, May 7, 10:43
PiRK requested review of this revision.Tue, May 7, 10:43
teamcity edited the summary of this revision. (Show Details)Tue, May 7, 10:43
Harbormaster completed remote builds in B28924: Diff 47659.Tue, May 7, 11:00
Fabien accepted this revision.Tue, May 7, 13:11
This revision is now accepted and ready to land.Tue, May 7, 13:11
Closed by commit rABC6807143b114f: Split non/kernel chainparams (authored by PiRK). · Explain WhyMon, May 13, 05:47
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC6807143b114f: Split non/kernel chainparams.

Revision Contents
Changeset List

PathSize
src/
2 lines
6 lines
163 lines
496 lines
6 lines
8 lines
kernel/
41 lines
62 lines
2 lines
node/
2 lines
test/
util/
1 line
2 lines
1 line

Diff 47737

View Options

src/CMakeLists.txt

Loading...
View Options

src/bitcoin-chainstate.cpp

Loading...
View Options

src/chainparams.h

Loading...
View Options

src/chainparams.cpp

Loading...
View Options

src/config.h

Loading...
View Options

src/config.cpp

Loading...
View Options

src/kernel/chainparams.h

Loading...
View Options

src/kernel/chainparams.cpp

Loading...
View Options

src/mempool_args.cpp

Loading...
View Options

src/node/blockstorage.cpp

Loading...
View Options

src/test/util/setup_common.h

Loading...
View Options

src/validation.h

Loading...
View Options

src/validation.cpp

Loading...