Page MenuHomePhabricator

[nsis] Fix build error due to images not found
ClosedPublic

Authored by Fabien on May 9 2024, 09:25.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABC1a331b6bc2b1: [nsis] Fix build error due to images not found
Summary

The NSIS installer installs the docs, i.e. the .md and .png files from the doc/ directory. Since the bitcoin_logo_doxygen.png file is excluded, there is no such file left since D16127. We could remove the lookup for images but it's more robust to just add a /nonfatal switch to avoid failing NSIS if no image is in the directory.

Test Plan
./contrib/teamcity/build-configurations.py build-win64

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable