Page MenuHomePhabricator
Differential D16139

[e.cash] Changing the Main Copy of the "Avalanche" section in Core-Tech.
ClosedPublic
Actions

Authored by Kronkmeister on May 9 2024, 23:44.

Details

Reviewers
Mengerian
Group Reviewers
Restricted Project
Commits
rABC7235997718a0: [e.cash] Changing the Main Copy of the "Avalanche" section in Core-Tech.
Summary

Adding more benefits of Avalanche and removing mention of BCH forks.

Test Plan

visit e.cash/core-tech scroll down to Avalanche and double check copy.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
Core-Tech-Avalanche-Copy
Lint
Lint Errors
SeverityLocationCodeMessage
Errorweb/e.cash/pages/core-tech.js:92ESLINTreact/no-unescaped-entities
Unit
No Test Coverage
Build Status
Buildable 28973
Build 57483: Build Diff
Build 57482: arc lint + arc unit

Event Timeline

Kronkmeister created this revision.May 9 2024, 23:44
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 9 2024, 23:44
Kronkmeister requested review of this revision.May 9 2024, 23:44
Harbormaster completed remote builds in B28970: Diff 47723.May 9 2024, 23:44
Kronkmeister updated this revision to Diff 47724.May 10 2024, 00:00

Fixing the Abostrophe Issue. Changing the word "developments" into singular.

Harbormaster completed remote builds in B28971: Diff 47724.May 10 2024, 00:00
Kronkmeister updated this revision to Diff 47725.May 10 2024, 04:23
Kronkmeister retitled this revision from [website] Changing the Main Copy of the "Avalanche" section in Core-Tech. Adding more benefits of eCash and removing mention of BCH forks to [e.cash] Changing the Main Copy of the "Avalanche" section in Core-Tech..
Kronkmeister edited the summary of this revision. (Show Details)

changed description for readability

Harbormaster completed remote builds in B28972: Diff 47725.May 10 2024, 04:23
Mengerian added a subscriber: Mengerian.May 10 2024, 04:35

@bot preview-e.cash

teamcity awarded a token.May 10 2024, 04:35

Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://54.39.104.128:41313 for the next 60 minutes.

Mengerian requested changes to this revision.May 10 2024, 04:40

Apostrophe is broken

web/e.cash/pages/core-tech.js
92 ↗(On Diff #47725)
This revision now requires changes to proceed.May 10 2024, 04:40
Kronkmeister updated this revision to Diff 47726.May 10 2024, 16:24

Fixing the Apostrophe issue for good and editing some copy.

Harbormaster completed remote builds in B28973: Diff 47726.May 10 2024, 16:24
Kronkmeister updated this revision to Diff 47727.May 10 2024, 16:28

Accidentally reintroduced the apostrophe error in previous diff. This time it is fixed for good.

Harbormaster completed remote builds in B28974: Diff 47727.May 10 2024, 16:28
Kronkmeister added a comment.May 10 2024, 16:28

@bot preview-e.cash

teamcity updated a token.May 10 2024, 16:28

Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://54.39.104.128:41081 for the next 60 minutes.

Mengerian accepted this revision.May 10 2024, 16:59
This revision is now accepted and ready to land.May 10 2024, 16:59
Closed by commit rABC7235997718a0: [e.cash] Changing the Main Copy of the "Avalanche" section in Core-Tech. (authored by Kronkmeister). · Explain WhyMay 10 2024, 17:13
This revision was automatically updated to reflect the committed changes.
Kronkmeister added a commit: rABC7235997718a0: [e.cash] Changing the Main Copy of the "Avalanche" section in Core-Tech..

Revision Contents
Changeset List

PathSize
web/
e.cash/
pages/
10 lines

Diff 47726

View Options

web/e.cash/pages/core-tech.js

Loading...