Page MenuHomePhabricator
Differential D16173

Replace May 15, 2024 activation with Nov 15
ClosedPublic
Actions

Authored by Fabien on May 16 2024, 09:26.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABC4faa4923ec82: Replace May 15, 2024 activation with Nov 15
Summary

The upgrade has completed, move the code to the next upgrade. Since this was policy only, we can just pretend it never happened:

  • Update the activation code to november
  • Update the tests to always use the new policy
Test Plan
ninja all check-extended check-extended-upgrade-activated

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.May 16 2024, 09:26
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 16 2024, 09:26
Fabien requested review of this revision.May 16 2024, 09:26
Harbormaster completed remote builds in B29027: Diff 47811.May 16 2024, 09:57
PiRK accepted this revision.May 16 2024, 10:06
PiRK added a subscriber: PiRK.
PiRK added inline comments.
src/avalanche/peermanager.cpp
985–998 ↗(On Diff #47811)

Now that the slack is always symmetric we could simplify and clarify this a bit. What do you think?
Not in this diff, though.

This revision is now accepted and ready to land.May 16 2024, 10:06
Closed by commit rABC4faa4923ec82: Replace May 15, 2024 activation with Nov 15 (authored by Fabien). · Explain WhyMay 16 2024, 10:28
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC4faa4923ec82: Replace May 15, 2024 activation with Nov 15.

Revision Contents
Changeset List

PathSize
src/
avalanche/
15 lines
test/
70 lines
2 lines
consensus/
7 lines
14 lines
2 lines
4 lines
kernel/
9 lines
test/
4 lines
25 lines
test/
4 lines
functional/
4 lines
test_framework/
18 lines
lint/
4 lines

Diff 47812

View Options

src/avalanche/peermanager.cpp

Loading...
View Options

src/avalanche/test/peermanager_tests.cpp

Loading...
View Options

src/avalanche/test/processor_tests.cpp

Loading...
View Options

src/consensus/activation.h

Loading...
View Options

src/consensus/activation.cpp

Loading...
View Options

src/consensus/params.h

Loading...
View Options

src/init.cpp

Loading...
View Options

src/kernel/chainparams.cpp

Loading...
View Options

src/test/CMakeLists.txt

Loading...
View Options

src/test/activation_tests.cpp

Loading...
View Options

test/CMakeLists.txt

Loading...
View Options

test/functional/abc_mining_stakingrewards.py

Loading...
View Options

test/functional/test_framework/test_framework.py

Loading...
View Options

test/lint/check-doc.py

Loading...