Page MenuHomePhabricator

[Cashtab] Show full-height screen with no nav footer for onboarding page
ClosedPublic

Authored by bytesofman on May 28 2024, 17:14.

Details

Summary

Hangover from earlier CSS scroll head patches in Cashtab. The height of hte wallet body component is set to leave exact space for the footer, so that we have no unnecessary scrolling.

On the onboarding page, we disable the footer, as we do not want navigation to any screens until the user has a wallet.

Adjust height of container for this case so there is not an empty space where the footer should be.

Test Plan

npm start, open localhost:3000 in an incognito window, note there is no gap at the bottom, create a wallet, note footer is present

before:

image.png (965×563 px, 88 KB)

after:

image.png (965×563 px, 84 KB)

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable