Page MenuHomePhabricator
Differential D16246

rpc: Set RPCArg options with designated initializers
ClosedPublic
Actions

Authored by Fabien on May 29 2024, 19:30.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABC1a62bc71c3dc: rpc: Set RPCArg options with designated initializers
Summary
For optional constructor arguments, use a new struct. This comes with two benefits:

    Earlier unused optional arguments can be omitted
    Designated initializers can be used

Backport of core#26074.

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.May 29 2024, 19:30
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 29 2024, 19:30
Fabien requested review of this revision.May 29 2024, 19:30
teamcity edited the summary of this revision. (Show Details)May 29 2024, 19:30
Harbormaster completed remote builds in B29167: Diff 48027.May 29 2024, 19:47
PiRK accepted this revision.May 30 2024, 08:17
PiRK added a subscriber: PiRK.
PiRK added inline comments.
src/wallet/rpc/backup.cpp
1724–1726 ↗(On Diff #48027)

the layout can be improved for the above 3 lines

This revision is now accepted and ready to land.May 30 2024, 08:17
Closed by commit rABC1a62bc71c3dc: rpc: Set RPCArg options with designated initializers (authored by MacroFake <falke.marco@gmail.com>, committed by Fabien). · Explain WhyMay 30 2024, 08:27
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC1a62bc71c3dc: rpc: Set RPCArg options with designated initializers.

Revision Contents
Changeset List

PathSize
src/
rpc/
18 lines
2 lines
9 lines
51 lines
18 lines
wallet/
rpc/
93 lines
11 lines

Diff 48034

View Options

src/rpc/blockchain.cpp

Loading...
View Options

src/rpc/mining.cpp

Loading...
View Options

src/rpc/server.cpp

Loading...
View Options

src/rpc/util.h

Loading...
View Options

src/rpc/util.cpp

Loading...
View Options

src/wallet/rpc/backup.cpp

Loading...
View Options

src/wallet/rpcwallet.cpp

Loading...