Page MenuHomePhabricator
Differential D16331

[ecashaddrjs] Fix types for `isValidCashAddress`
ClosedPublic
Actions

Authored by andreazllin on Jun 13 2024, 22:40.

Details

Reviewers
bytesofman
Fabien
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABC481fcc4e5ce1: [ecashaddrjs] Fix types for `isValidCashAddress`
Summary

TypeScript gives an error when optionalPrefix in not defined when calling isValidCashAddress, this PR allows both undefined or explicit false for no prefixes, or a user passed string as prefix

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

andreazllin created this revision.Jun 13 2024, 22:40
Owners added a reviewer: Restricted Owners Package.Jun 13 2024, 22:40
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 13 2024, 22:40
andreazllin requested review of this revision.Jun 13 2024, 22:40
Harbormaster completed remote builds in B29294: Diff 48238.Jun 13 2024, 22:42
andreazllin edited the test plan for this revision. (Show Details)Jun 13 2024, 22:58
andreazllin edited the summary of this revision. (Show Details)Jun 13 2024, 23:09
andreazllin edited the summary of this revision. (Show Details)
bytesofman requested changes to this revision.Jun 13 2024, 23:33

nice, thanks!

please

  • run npm version patch to bump the version number
  • update README.md #### Changelog section to describe the change

and will get this in

This revision now requires changes to proceed.Jun 13 2024, 23:33
andreazllin updated this revision to Diff 48241.Jun 14 2024, 08:34
andreazllin edited the summary of this revision. (Show Details)
  • Update package version
  • Add version to README.md Changelog
Harbormaster completed remote builds in B29297: Diff 48241.Jun 14 2024, 08:35
bytesofman accepted this revision.Jun 14 2024, 12:42
This revision is now accepted and ready to land.Jun 14 2024, 12:42
bytesofman added a comment.Jun 15 2024, 12:09

You can ping me on Telegram @bytesofman if you need support for landing this diff 🙏

Closed by commit rABC481fcc4e5ce1: [ecashaddrjs] Fix types for `isValidCashAddress` (authored by Andrea <andrea.lin3110@gmail.com>). · Explain WhyJun 16 2024, 17:28
This revision was automatically updated to reflect the committed changes.
Andrea <andrea.lin3110@gmail.com> added a commit: rABC481fcc4e5ce1: [ecashaddrjs] Fix types for `isValidCashAddress`.

Revision Contents
Changeset List

PathSize
modules/
ecashaddrjs/
1 line
4 lines
2 lines
src/
2 lines

Diff 48255

View Options

modules/ecashaddrjs/README.md

Loading...
View Options

modules/ecashaddrjs/package-lock.json

Loading...
View Options

modules/ecashaddrjs/package.json

Loading...
View Options

modules/ecashaddrjs/src/cashaddr.d.ts

Loading...