Page MenuHomePhabricator

[electrum] fix support for Ledger app versions >= 2.4.0
ClosedPublic

Authored by PiRK on Jun 21 2024, 08:04.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCad005c298d17: [electrum] fix support for Ledger app versions >= 2.4.0
Summary

See https://github.com/LedgerHQ/lib-app-bitcoin/commit/2c61ac016167e39ada8225009644358935f1cdb0

On app versions >=2.4.4 getOperationMode has been restored by Ledger to support the legacy btchip lib, but it no longer does anything useful, so no need to call it.
See https://github.com/LedgerHQ/lib-app-bitcoin/pull/5

enableAlternate2fa is still broken on v2.4.4, and if it is restored in a future version it will likewise be a no-op just for legacy support.
See https://github.com/LedgerHQ/lib-app-bitcoin/pull/7

So just skip these calls on recent versions. Keep them for previous versions of the BCH app and for HW1 support.

Test Plan

Loaded a Ledger wallet and signed a transaction with the 2.4.4 app installed.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable