[chronik] Determine lokad indexing by enable_lokad_id_index param
ClosedPublic
Actions

Authored by bytesofman on Wed, Jul 3, 16:33.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC439fe1a5f2b9: [chronik] Determine lokad indexing by enable_lokad_id_index param

Summary

Typo bug where enabling the lokad index is determined by the enable_token_index param

Patch so the enable_lokad_id_index param behaves as expected

Test Plan

mkdir buildChronik
pushd buildChronik
cmake -GNinja .. -DBUILD_BITCOIN_CHRONIK=ON
ninja
ninja check-functional
cd test/functional
./test_runner.py chronik_lokad_id_group

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bytesofman created this revision.Wed, Jul 3, 16:33

Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, Jul 3, 16:33

Harbormaster completed remote builds in B29462: Diff 48486.Wed, Jul 3, 16:57

update functional test

Harbormaster completed remote builds in B29474: Diff 48508.Thu, Jul 4, 14:30

lint

bytesofman published this revision for review.Thu, Jul 4, 14:32

bytesofman edited the test plan for this revision. (Show Details)

bytesofman added inline comments.

test/functional/chronik_lokad_id_group.py

271 ↗

(On Diff #48509)

Before making the change to line 221 of indexer.rs, I got this test file to pass with these lines instead:

# Restarting with chroniklokadidindex=0 and chroniktokenindex=1 accidentally reindexes the LOKAD ID index
# but only for confirmed txs
self.restart_node(0, ["-chronik", "-reindex", "-chroniktokenindex=1", "-chroniklokadidindex=0"])
assert_equal(lokad_id_conf(b"lok0"), sorted([tx0.hash, tx1.hash, tx2.hash]))
assert_equal(lokad_id_conf(b"lok1"), [tx1.hash])
assert_equal(lokad_id_conf(b"lok2"), [tx2.hash])

Harbormaster completed remote builds in B29475: Diff 48509.Thu, Jul 4, 15:14

Fabien accepted this revision.Thu, Jul 4, 18:10

Fabien added a subscriber: Fabien.

Fabien added inline comments.

test/functional/chronik_lokad_id_group.py
272 ↗	(On Diff #48509)	not only for confirmed txs, unconfirmed are also not indexed. Just simplify the comment: `# Restarting with chroniklokadidindex=0 and chroniktokenindex=1 DOES NOT reindex the LOKAD ID index`